jsramraj / flags

Simple no nonsense library for getting flag icon for any country

Hi there 👋

👨🏻‍💻 About Me

• I am a software engineer who loves programming, reading, driving and playing games.
• I am specialized in building mobile apps.
• I am a great team player with a growth mindset.
• I have bachelor's degree engineering. But I strongly feel that all your academic degree and certificates doesn't matter unless you keep learning.
• I am currently working as a Software Engineering Lead at Trimble, Inc in Chennai, India

🛠 Tech Stack

Programming Languages

Tech Stack

📫 Reach Me

flags's Issues

About the sprite

May i ask why the sprite is wasting a lot of empty space? All the flags could be put together, to make a smaller and lighter file..

Flags should not be storing context in the static reference. Potential to m/m leaks!

Hey @jsramraj,
Long time no see. Just got to see this library. Great attempt to solve this problem!
I am raising one issue which I saw while skimming through the code.

flags/flags/src/main/java/com/jsramraj/flags/Flags.java

Line 22 in 5ba586b

public static void init(final Context ctx) {

1. Instead of storing the activity context, it should passed into the method calls every time, if it relies on Activity context.
2. If it relies of application context, then we can use this approach but the caveat is you will not be able to take the benefits of localisation, application contexts do not give you localised strings, they will fallback to english.

Solving the existing code, requires something like a builder.
Flags.with(context).forCountry()

To make it even better and testable, separate out the user API forCountry in some

interface FlagDrawableProvider {
   public BitmapDrawable forCountry(enum or @StringDef countryCode);
}

When, user calls with(), library returns a concrete implementation of FlagDrawableProviderie Flags. This makes sure that user is not able to access any other method apart from API and we can get rid of all static keywords in the methods, and you can mock them in unit tests.
and if context is null or not an instance of AppCompatActivity, library can throw an exception.

Edit:

public static FlagDrawableProvider with(@NonNull final Context ctx) {'
        if(!ctx instanceof AppCompatActivity ) {
              throw new IllegalArgumentException("Some Message");
         }
        return new Flags();      // In real time, you might want to initialise only for the first time and for 
                                              // next calls reuse the same Flags instance.
    }