jtnix / jquery-flyout Goto Github PK

suggested fix :
$(bigimg).on("load", function() { var imgtag = $("<img/>") .attr("src", $holder.attr("href")) .attr("title", ((typeof($thumb.attr("title"))=="undefined")?"":$thumb.attr("title")) + o.closeTip) // pk .attr("alt", ((typeof($thumb.attr("alt"))=="undefined")?"":$thumb.attr("alt")) + o.closeTip) // pk .height(th) .width(tw); .....

I started to upgrade my project using JQueyFlyOut from JQuery 2.0 to JQuery 3.1..

It was working great with JQuery 2.0 and does not work anymore with JQuery 3.1...

I started to debug it and noticed that variable names starting with the "$" sign did no more receive accurate content ($holder $thumb $loader)...

then I have a problem with the following lines:

if (o.loadingSrc) {
            $('#'+o.loader).append($('<img/>')
                            .load(function() {
                                    $(this)
                                        .css({'position':'relative',
                                             'top':th/2-(this.height/2),
                                             'left':tw/2-(this.width/2)})
                                        .attr('alt',o.loadingText);
                                    })
                                .attr('src',o.loadingSrc)
                            );

it seems that the $(this) Inside load(function() has not the expected value, but I did not go further..

Thanks for having a look and a fix to it....

Cheers,
Pascal