ju1ius / html-email-preflight Goto Github PK

There is a call to an undefined method which is if(!Encoding::isSameEncoding($encoding, 'utf-8')) { on line 200 of EmailPreflight.php which is refering to ju1ius\Text\Encoding::isSameEncoding() but it does not exist.

Hi,

Seems like this repo has not been updated in a while, wanted your suggestion if we should go with this or not.

Awesome work with this port. Using it with your awesome CSS-Parser too.

This is a small issue but common for email designers to use.

The a:link selector is the same as the a selector. However, this doesn't get in-lined.

Hi Ju1ius,

I think this is in your to do list but I've been trying to figure this error out for the past hour with how your consume works with chars. Didn't get very far!

I am basically trying to get it to inline when using an absolute URL. But I get this error. Any direction on how to fix this or what's causing this?

  Fatal error: Uncaught exception 'ju1ius\Css\Exception\ParseException' with message 'Tried to consume 1 chars, exceeded file end in    http://localhost/master.css on line 88, column 2' in 
  C:\classes\helpers\ju1ius\Css\AbstractParser.php:229 Stack trace: #0 
  C:\classes\helpers\ju1ius\Css\Parser.php(1023): ju1ius\Css\AbstractParser->_consume(1) #1 
  C:\classes\helpers\ju1ius\Css\Parser.php(160): ju1ius\Css\Parser->_skipStyleRule() #2 
  C:\classes\helpers\ju1ius\Css\Parser.php(102): ju1ius\Css\Parser->_parseRuleList(Object(ju1ius\Css\RuleList), true) 
  #3 C:classes\helpers\ju1ius\Css\Parser.php(64): ju1ius\Css\Parser->_parseStyleSheet(Object(ju1ius\Css\StyleSheet)) #4
   C:\classes\helpers\ju1ius\Css\Parser.php(53): ju1ius\Css\Parser->parseStyleSheet(Object(ju1ius\Text\Source\File)) #5 
  C:\classes\helpers\ju1ius\Html\EmailPreflight.php(451): ju1 in ju1ius\Css\AbstractParser.php on line 229

Btw, are you based in London by any chance?

If a CSS property is already in line for example:

  <p style="color: red;">Hello there</p>

The email preflight does not change the color red to its hex value. However, if its in an embeded style block then the color does get converted to hex.

Is this intentional?

I think this is already on your to do list but when a link to a style sheet is invalid or its a relative URL, this error is thrown:

Fatal error: Call to a member function parseMediaQuery() on a non-object in EmailPreflight.php on line 440

Those invlaid links or relative URLs probably should just be ignored.