juancarlospaco / cpython Goto Github PK

these appear in each module (with minor modifications):

template X(simbol):       auto = nimpy.pyImport("crypt").simbol().to(type(result))
template X(simbol; a):    auto = nimpy.pyImport("crypt").simbol(a).to(type(result))
template X(simbol; a, b): auto = nimpy.pyImport("crypt").simbol(a, b).to(type(result))

can you instead add a private module pyutils which you import in each module, possibly with a macro eg:

# pyutils.nim:
macro genWrappers*(name: string) =
  template X(simbol):       auto = nimpy.pyImport(name).simbol().to(type(result))
  template X(simbol; a):    auto = nimpy.pyImport(name).simbol(a).to(type(result))
  template X(simbol; a, b): auto = nimpy.pyImport(name).simbol(a, b).to(type(result))

# in crypt.nim:
import pyutils
genWrappers("crypt")

...

As a developer
I want known why
So that I can decide if I should use it or not

My own experience: I could only realize why you did it, when you mention nodejs lib, maybe for someone without that previous knowledge it would be harder.

Nice related content: https://sketchplanations.com/the-golden-circle

Sorry it should be a pull request, but I'm not confident with my English neither the why or pros/cons, of use your lib.

eg https://juancarlospaco.github.io/cpython/theindex.html gives 404

also, with such working index you wouldn't neeed to maintain a (manually generated?) README with the docs which does essentially the same;

example

see how other packages handle this, eg:

• https://github.com/nitely/nim-regex => "Read the docs" https://nitely.github.io/nim-regex/regex.html
• https://github.com/citycide/glob
• https://github.com/kaushalmodi/std_vector

testing

Looking at the source, this is just using python under the hood,
so same performance characteristics.

The project is laudable, but why not replace at least the obvious parts with Nim code?
Then it would make ported python that use your library much faster.

Hello!

I hope you are doing well!

We are a security research team. Our tool automatically detected a vulnerability in this repository. We want to disclose it responsibly. GitHub has a feature called Private vulnerability reporting, which enables security research to privately disclose a vulnerability. Unfortunately, it is not enabled for this repository.

Can you enable it, so that we can report it?

Thanks in advance!

PS: you can read about how to enable private vulnerability reporting here: https://docs.github.com/en/code-security/security-advisories/repository-security-advisories/configuring-private-vulnerability-reporting-for-a-repository

• how did you generate the APIS? nimterop? (obviously not c2nim ...)

• how is this maintained/kept up to date?

• syntax highlight is broken eg https://github.com/juancarlospaco/cpython/blob/nim/src/cpython/base64.nim

• Same API as Python StdLib, same function names, same argument names.
  => maybe give more details (eg regarding how trailing _ are handled, since illegal ... for now)

• It does not use anything from Nim standard library, very future-proof.

this needs clarification, because it uses nimpy (which itself uses stdlib)

• nimpy (which is the thing that makes it all work) should be clearly mentioned (with a link also) in the README