jugglinmike / amdclean Goto Github PK

In cases where external libraries that define AMD have deeply nested defines, the replacement mechanism using var __DEFINE_X__ will not work as expected.

Example with Lo-Dash:

if (typeof define == 'function' && typeof define.amd == 'object' && define.amd) {
  // Expose Lo-Dash to the global object even when an AMD loader is present in
  // case Lo-Dash was injected by a third-party script and not intended to be
  // loaded as a module. The global assignment can be reverted in the Lo-Dash
  // module by its `noConflict()` method.
  root._ = lodash;

  // define as an anonymous module so, through path mapping, it can be
  // referenced as the "underscore" module
  var __DEFINE_0__ = (function(){
    return lodash;
  })();
}

I do not want us to utilize globals, but maybe we can utilize a module cache to store references in?

The question would also be how do we inject our own cache to not become global. Perhaps we advocate to use start and end files to handle it.

Edit: Upon further inspection that code path would never be hit and subsequently never normalized. I think this could be even more problematic.

For those using this to generate a reusable library.

• Automatically wire up start/end wrap.
• SourceMap support going back to original source.
• Make identifiers pretty instead of mangled.
• Compile to CJS/ES6

Update context to be a constructor that contains instance-specific module registrations.

• Renaming of CommonJS arguments (you only need to match the first argument require to tell it it's CommonJS the rest can be named whatever).
• module.exports vs return value (module.exports will take precedence in a truthy tie, otherwise, whichever is truthy module.exports || retVal).
• Shim configuration (RequireJS/R.js specific).
• require transformations.
• Linking require correctly to define.
• Relative module requires.
• namespace[identifier] format.

https://github.com/mozilla/source-map

Since we are directly modifying the source code, we'll need to record the state prior to calling node.update.

This would be very interesting for post-install/install hooks.

Instead of rewriting libraries that use AMD, simply transpile when installed via NPM.

mozilla/source-map#67

Run the moduleName through a function that can generate a pretty and valid JavaScript identifier. This will help avoid the need to mangle the identifier for uniqueness.

We should provide options to make it easier to wrap your final build in a highly consumable UMD wrapper.

defines that use literals should not be converted to IIFE that return the value, we should just directly assign.

Example:

define(1234);

which currently compiles to:

var __AMDCLEAN0__ = (function() {
  return 1234;
})();

but, should be optimized to:

var __AMDCLEAN0__ = 1234;