jujalabs / teams-slack-bot Goto Github PK

Create REST end-point in Controller. All business logic should be in Service layer.
technical specification

In accordance with https://api.slack.com/changelog/2017-09-the-one-about-usernames

Create new branch 'hotfix_replace_slack_usernames_by_user_id' inherited of master.

1. Change slackNamePattern;
2. Replace all logic 'finding by slackNames' by 'finding by Ids'.
3. Update tests

Add Swagger API tool

Create REST end-point in Controller. All business logic should be in Service layer.
technical specification

Remove urls from properties to Controller and Feign interface

Check test code coverage in whole project.

Create REST end-point in Controller. All business logic should be in Service layer.
technical specification

Check log coverage in whole project.

Create REST end-point in Controller. All business logic should be in Service layer.
technical specification

All parsing, converting, conversions should be in utils class. At the same time this class has to be separate of business logic and could be transformed in library in the future.

Add auto build this repository in docker hub.
Please send PR to release branch

In accordance with https://api.slack.com/changelog/2017-09-the-one-about-usernames

1. Change slackNamePattern;
2. Replace all logic 'finding by slackNames' by 'finding by Ids'.
3. Update tests

Create REST end-point in Controller. All business logic should be in Service layer.
technical specification

1. plug in the library spring-aop
2. create config for aop (all methods start and finish with log)
3. remove logs about 'method started' and 'method finished'

Use full url in endpoints

teams.slackbot.rest.api.version=v1
teams.slackbot.commandsUrl=/commands
teams.slackbot.endpoint.activateTeam=/${teams.slackbot.rest.api.version}${teams.slackbot.commandsUrl}/teams/activate
teams.slackbot.endpoint.deactivateTeam=/${teams.slackbot.rest.api.version}${teams.slackbot.commandsUrl}/teams/deactivate
teams.slackbot.endpoint.getTeam=/${teams.slackbot.rest.api.version}${teams.slackbot.commandsUrl}/teams
teams.slackbot.endpoint.getMyTeam=/${teams.slackbot.rest.api.version}${teams.slackbot.commandsUrl}/myteam

instead

teams.slackbot.commandsUrl=/commands
teams.slackbot.rest.api.version=v1
teams.slackbot.endpoint.activateTeam=/teams/activate
teams.slackbot.endpoint.deactivateTeam=/teams/deactivate
teams.slackbot.endpoint.getTeam=/teams
teams.slackbot.endpoint.getMyTeam=/myteam
teams.slackbot.endpoint.heartBeat=/heart

refactor controller/repositories methods mapping and tests