GithubHelp home page GithubHelp logo

Comments (3)

KristofferC avatar KristofferC commented on September 26, 2024

My guess is that this has something to do with the (in my opinion) non ideal implementation of disabling getindex.

from sparsearrays.jl.

rayegun avatar rayegun commented on September 26, 2024

It does. I wonder if you know of a better way? IIRC it was based on how CUDA does it

from sparsearrays.jl.

SobhanMP avatar SobhanMP commented on September 26, 2024

I think there are two other ways to do it, add a global Ref{Bool} can_index state that is checked by those functions, or store it as part of the matrix/type of the matrix.

From a performance perspective, the current implementation is the safest and most compatible; small benchmarks do not convince me that the global state does not hurt performance. And at the end of the day, this is just for debugging, not something anyone should use in production.

from sparsearrays.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.