GithubHelp home page GithubHelp logo

Comments (7)

ViralBShah avatar ViralBShah commented on July 23, 2024 1

The problem right now is that SparseArrays.jl is a Julia stdlib, and I believe it can't be removed. Something to do with type piracy of * and . @KristofferC tried to excise it and realized we couldn't.

I would personally prefer to get it excised and also LinearAlgebra, and I also like the idea of the Interfaces package. In the meanwhile we can certainly add the types and machinery you suggest so that they can be extended by downstream packages.

Would be good to have @SobhanMP and @rayegun chime in as well, before any PRs are put together.

from sparsearrays.jl.

SobhanMP avatar SobhanMP commented on July 23, 2024 1

The interface is generic; I only added CSC and dense matrix support because that's what's implemented in this package. Nothing is really stopping you from adding CSR support, and it should be composable with other types. https://sobhanmp.github.io/SparseExtra.jl/iternz/

from sparsearrays.jl.

j-fu avatar j-fu commented on July 23, 2024

Just FYI: there is also https://github.com/gridap/SparseMatricesCSR.jl

from sparsearrays.jl.

termi-official avatar termi-official commented on July 23, 2024

Thanks Jürgen. Let me then also mention for completeness of the thread the packages
https://github.com/BacAmorim/ThreadedSparseCSR.jl/
https://github.com/youwuyou/Ginkgo.jl
https://github.com/fredrikekre/HYPRE.jl
providing CSR formats

from sparsearrays.jl.

termi-official avatar termi-official commented on July 23, 2024

Thanks for the additional context @ViralBShah . I went ahead and drafted what I have in mind and could need some feedback. The alternative would be to move the CSR code into a different package for now (SparseMatricesCSR.jl, if it is still maintained?) and strip the open PR down to the changes which are necessary to enable the AbstractSparseMatrixCSR interface.

Edit: If there is a third option I am still happy to hear. (And no worries, I have not forgot about the sparse matrix iterator interface tho Raye)

from sparsearrays.jl.

SobhanMP avatar SobhanMP commented on July 23, 2024

forgot about the sparse matrix iterator interface tho Raye

Is this something different than #167?

from sparsearrays.jl.

termi-official avatar termi-official commented on July 23, 2024

From what I understood Raye's idea was to have a generic interface which works across different formats. The PR looks like it is tailored to provide iterators primarily with CSC in mind

@inline getcolptr(x::SparseIndexIterate) = getcolptr(x.m)
@inline getrowval(x::SparseIndexIterate) = getrowval(x.m)
@inline getnzval(x::SparseIndexIterate) = getnzval(x.m)

right?

from sparsearrays.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.