Comments (3)
JamesWrigley
commented on June 21, 2024
1
Amazingly I was literally just looking into this ๐ At least on 1.10.2 I still see these invalidations, I can't easily check on 1.11 because Cthulu/JET don't support it yet. So I think it should be kept open.
from sparsearrays.jl.
ViralBShah
commented on June 21, 2024
Can we close this?
from sparsearrays.jl.
JamesWrigley
commented on June 21, 2024
I was finally able to check the invalidations on 1.11 and it seems to be fixed ๐ They don't appear for Dagger.jl or Polymake.jl anymore. Here's the output from snooping on Polymake on 1.11:
julia> using SnoopCompileCore
julia> invalidations = @snoopr using Polymake;
julia> using SnoopCompile
[ Info: Precompiling SnoopCompile [aa65fe97-06da-5843-b5b1-d5d13cad87d2] (cache misses: wrong dep version loaded (2))
julia> trees = invalidation_trees(invalidations);
julia> @show length(uinvalidated(invalidations))
length(uinvalidated(invalidations)) = 1009
1009
julia> using PrettyTables
julia> report_invalidations(; invalidations, n_rows=0)
[ Info: 1009 methods invalidated for 18 functions
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฌโโโโโโโโโโโโโโโโฌโโโโโโโโโโโโโโโโฌโโโโโโโโโโโโโโโโโโ
โ <file name>:<line number> โ Function Name โ Invalidations โ Invalidations % โ
โ โ โ โ (xแตข/โx) โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโผโโโโโโโโโโโโโโโโผโโโโโโโโโโโโโโโโผโโโโโโโโโโโโโโโโโโค
โ /home/james/.julia/packages/CxxWrap/5IZvn/src/CxxWrap.jl:121 โ Number โ 1047 โ 66 โ
โ /home/james/.julia/packages/Mongoc/tJNDW/src/bson.jl:501 โ convert โ 295 โ 19 โ
โ /home/james/.julia/packages/Mongoc/tJNDW/src/bson.jl:324 โ convert โ 53 โ 3 โ
โ /home/james/.julia/packages/CxxWrap/5IZvn/src/CxxWrap.jl:687 โ convert โ 45 โ 3 โ
โ /home/james/.julia/packages/CxxWrap/5IZvn/src/StdLib.jl:133 โ show โ 40 โ 3 โ
โ /home/james/.julia/packages/CxxWrap/5IZvn/src/StdLib.jl:40 โ thisind โ 34 โ 2 โ
โ /home/james/.julia/packages/Mongoc/tJNDW/src/bson.jl:496 โ keys โ 23 โ 1 โ
โ /home/james/.julia/packages/CxxWrap/5IZvn/src/CxxWrap.jl:687 โ convert โ 14 โ 1 โ
โ /home/james/.julia/packages/Polymake/fF0a6/src/meta.jl:359 โ getdoc โ 10 โ 1 โ
โ /cache/build/builder-amdci5-5/julialang/julia-release-1-dot-11/usr/share/julia/stdlib/v1.11/Pkg/src/Pkg.jl:48 โ print โ 8 โ 1 โ
โ /home/james/.julia/packages/DecFP/Cud5F/src/DecFP.jl:540 โ isnan โ 4 โ 0 โ
โ /cache/build/builder-amdci5-5/julialang/julia-release-1-dot-11/usr/share/julia/stdlib/v1.11/SparseArrays/src/readonly.jl:17 โ eachindex โ 2 โ 0 โ
โ /home/james/.julia/packages/Mongoc/tJNDW/src/bson.jl:499 โ convert โ 1 โ 0 โ
โ /home/james/.julia/packages/DecFP/Cud5F/src/DecFP.jl:524 โ one โ 1 โ 0 โ
โ /home/james/.julia/packages/DecFP/Cud5F/src/DecFP.jl:525 โ zero โ 1 โ 0 โ
โ /home/james/.julia/packages/SpecialFunctions/QH8rV/src/expint.jl:8 โ * โ 0 โ 0 โ
โ /cache/build/builder-amdci5-5/julialang/julia-release-1-dot-11/usr/share/julia/stdlib/v1.11/SparseArrays/src/higherorderfns.jl:1188 โ map! โ 0 โ 0 โ
โ /cache/build/builder-amdci5-5/julialang/julia-release-1-dot-11/usr/share/julia/stdlib/v1.11/SparseArrays/src/readonly.jl:33 โ resize! โ 0 โ 0 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโโโโโโAnd for Dagger.jl:
julia> include("test/invalidations.jl")
length(uinvalidated(invalidations)) = 510
[ Info: 510 methods invalidated for 24 functions
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโฌโโโโโโโโโโโโโโโโโโโฌโโโโโโโโโโโโโโโโฌโโโโโโโโโโโโโโโโโโ
โ <file name>:<line number> โ Function Name โ Invalidations โ Invalidations % โ
โ โ โ โ (xแตข/โx) โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโผโโโโโโโโโโโโโโโโโโโผโโโโโโโโโโโโโโโโผโโโโโโโโโโโโโโโโโโค
โ /home/james/.julia/packages/MemPool/jCpTk/src/read_write_lock.jl:119 โ lock โ 407 โ 65 โ
โ /home/james/.julia/packages/StaticArrays/EHHaF/src/SizedArray.jl:88 โ convert โ 41 โ 7 โ
โ /home/james/.julia/packages/ConcurrentCollections/QgIM8/src/dict.jl:672 โ IteratorSize โ 41 โ 7 โ
โ /home/james/.julia/packages/DataStructures/aD5vv/src/container_loops.jl:233 โ keys โ 27 โ 4 โ
โ /home/james/.julia/packages/FillArrays/3N7FG/src/FillArrays.jl:708 โ print_matrix_row โ 26 โ 4 โ
โ /home/james/.julia/packages/MemPool/jCpTk/src/read_write_lock.jl:133 โ unlock โ 17 โ 3 โ
โ /home/james/.julia/packages/StaticArrays/EHHaF/src/SArray.jl:71 โ unsafe_convert โ 16 โ 3 โ
โ /cache/build/builder-amdci5-5/julialang/julia-release-1-dot-11/usr/share/julia/stdlib/v1.11/StyledStrings/src/io.jl:248 โ print โ 14 โ 2 โ
โ /home/james/.julia/packages/FillArrays/3N7FG/src/fillalgebra.jl:396 โ reduce_first โ 5 โ 1 โ
โ /home/james/.julia/packages/StaticArrays/EHHaF/src/broadcast.jl:25 โ _axes โ 5 โ 1 โ
โ /home/james/.julia/packages/DataStructures/aD5vv/src/swiss_dict.jl:646 โ iterate โ 5 โ 1 โ
โ /home/james/.julia/packages/StaticArrays/EHHaF/src/SizedArray.jl:82 โ convert โ 4 โ 1 โ
โ /home/james/.julia/packages/DualNumbers/5knFX/src/dual.jl:171 โ convert โ 4 โ 1 โ
โ /home/james/.julia/packages/FillArrays/3N7FG/src/fillbroadcast.jl:258 โ broadcasted โ 3 โ 0 โ
โ /home/james/.julia/packages/StaticArrays/EHHaF/src/SOneTo.jl:57 โ getproperty โ 2 โ 0 โ
โ /cache/build/builder-amdci5-5/julialang/julia-release-1-dot-11/usr/share/julia/stdlib/v1.11/StyledStrings/src/io.jl:265 โ print โ 1 โ 0 โ
โ /cache/build/builder-amdci5-5/julialang/julia-release-1-dot-11/usr/share/julia/stdlib/v1.11/SparseArrays/src/readonly.jl:17 โ eachindex โ 1 โ 0 โ
โ /home/james/.julia/packages/DataStructures/aD5vv/src/sparse_int_set.jl:213 โ zip โ 1 โ 0 โ
โ /cache/build/builder-amdci5-5/julialang/julia-release-1-dot-11/usr/share/julia/stdlib/v1.11/REPL/src/Terminals.jl:48 โ displaysize โ 1 โ 0 โ
โ /cache/build/builder-amdci5-5/julialang/julia-release-1-dot-11/usr/share/julia/stdlib/v1.11/REPL/src/Terminals.jl:153 โ displaysize โ 1 โ 0 โ
โ /cache/build/builder-amdci5-5/julialang/julia-release-1-dot-11/usr/share/julia/stdlib/v1.11/Pkg/src/Pkg.jl:48 โ print โ 1 โ 0 โ
โ /cache/build/builder-amdci5-5/julialang/julia-release-1-dot-11/usr/share/julia/stdlib/v1.11/SharedArrays/src/SharedArrays.jl:575 โ map! โ 1 โ 0 โ
โ /home/james/.julia/packages/Graphs/czpTe/src/linalg/graphmatrices.jl:216 โ * โ 0 โ 0 โ
โ /cache/build/builder-amdci5-5/julialang/julia-release-1-dot-11/usr/share/julia/stdlib/v1.11/Profile/src/Profile.jl:45 โ lookup โ 0 โ 0 โ
โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโโโโดโโโโโโโโโโโโโโโโโโI think this can be closed now.
from sparsearrays.jl.
Related Issues (20)
- Wrapper generator needs updating to pick SuiteSparse headers from new location HOT 1
- Single precision support in CHOLMOD HOT 3
- Cholesky F.PtL \ Av where Av is a view does not work HOT 1
- Base.stack is underperforming for SparseArrays HOT 3
- Elementwise multiplication by a view of a dense matrix gives a dense matrix
- `findmin(A; dims=1)` is much slower than manually looping over. HOT 1
- Sparse array of string types HOT 17
- Memory Mapped SparseArrays HOT 3
- Extra allocations when using generalized `mul!` operation
- Attempting to run sparse `qr` produces StackOverflow when run on a sparse matrix of `ForwardDiff.Dual`. HOT 6
- Inconsistent addition between sparse and dense HOT 1
- `ldiv` of `LUFactorization` can throw `SingluarException` HOT 1
- Thread-safe dropstored! HOT 1
- Merge SparseMatricesCSR.jl in HOT 2
- Support zero-based indices HOT 3
- Windows threading tests fail in GitHub Actions CI but pass in Buildkite CI
- Problem when running old benchmarks in Oceananigans HOT 6
- Sparse matrix format interfaces HOT 3
- Clarify Cholmod version incompatibility message at build time and run time HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sparsearrays.jl.