juliushaertl / apporder Goto Github PK

Invalid argument supplied for foreach() at apps/apporder/util.php#55

Using owncloud 9.1 and AppOrder 0.3.2

I think Travis is failing because on the server master branch, which we check against, the version is set to 13, which is incompatible with the current settings in apporder's info.xml.
We could change the info.xml to <nextcloud min-version="12" max-version="13" /> and test against both the master and stable12 branch?

• basic testing environment
• unit tests for settingscontroller
• unit tests for configservice
• possible javascript tests

Using Nextcloud 12.

Expected:
The first item in the list set under apporder settings, is the default landing page for that user.

Actual:
Nextcloud does not respect the default landing page set by apporder (i.e. the first in the list), and reverts to going to the Files app when a user logs in.

Hi, I am sorry to get back to you again.
Today I updated both of your apps directmenu 0.91 --> 0.92 and apporder 0.30 --> 0.31 in NC 10.0, only. After the update was complete, i wanted to check and went to Administration--additional settings and received a blank white page! I loged aou and login as a "normal user". In the user section I did not found any menu to change the app order. Doing so by moving icons in the menu bar, worked, but diid not change the landing page after an additional logout - login process.

As a user, I set the mail app as landing page, but after login I received the usual files app as landing page!

reagrds, hitam4450

PS: After disabling apporder, everything in additional settings are visible !

Steps to reproduce

1. Browse over the application menu as shown in this screen capture
2. Note how (...) apps listed both text names and icons, but those along the top bar do not.

Expected behaviour

Applications would fill the entire top bar of my browser before the (...)
Possible to display just application Icons OR Text Names OR Both OR some combination of both.

Actual behaviour

Only 7 app icons are currently displayed before (...) despite having plenty of browser real estate.
I'm often confused when I see an icon and have no idea what it pertains to until I mouse over it to see the text name pop up.
No option to customize.
No option to display application names with no associated icons.

Hi, could you adjust your app so that transifex translations are possible?
In personal settings "App Order" the words dont follow the language of the rest of the page.

Hi,

I saw your fantastic AppOrder plugin (thank you!!), then I thought that if we want to push the idea further, it would be interesting to be able to set a default landing page per user as said in owncloud/core#8160.

I don't know if you plan to do it within your plugin.

Thanks,
HLFH

Steps to reproduce

1. Enable AppOrder
2. Open IE 11 and Login
3. See that appicons are not showing, but the links are available on the places of the icons!
4. Disable Apporder
5. Login again
6. See that appicons are showing

Firefox and Chrome are working like advertised

Expected behaviour

See : AppOrder_WithIcons.png
Icons must show in IE.

Actual behaviour

See : AppOrder_NoIcons.png
App Icons don't show when using IE.

General server configuration

Operating system: Linux mo 4.1.19-v7+ #858 SMP Tue Mar 15 15:56:00 GMT 2016 armv7l

Web server: nginx/1.6.2 (fpm-fcgi)

Database: mysql 5.5.57

PHP version: 5.6.30-0+deb8u1

 - Core
 - date
 - ereg
 - libxml
 - openssl
 - pcre
 - zlib
 - bcmath
 - bz2
 - calendar
 - ctype
 - dba
 - dom
 - hash
 - fileinfo
 - filter
 - ftp
 - gettext
 - SPL
 - iconv
 - mbstring
 - session
 - posix
 - Reflection
 - standard
 - shmop
 - SimpleXML
 - soap
 - sockets
 - Phar
 - exif
 - sysvmsg
 - sysvsem
 - sysvshm
 - tokenizer
 - wddx
 - xml
 - xmlreader
 - xmlwriter
 - zip
 - cgi-fcgi
 - PDO
 - apcu
 - curl
 - gd
 - json
 - mcrypt
 - memcache
 - memcached
 - mysql
 - mysqli
 - pdo_mysql
 - pdo_sqlite
 - readline
 - sqlite3
 - mhash
 - apc
 - Zend OPcache

Nextcloud configuration

Nextcloud version: 12.0.2 - 12.0.2.0

Updated from an older Nextcloud/ownCloud or fresh install:
YES

Where did you install Nextcloud from:
OC 9 =>NC 10,11,12

Are you using external storage, if yes which one: Array
(
[0] => \OC\Files\Storage\Local
)

Are you using encryption: no

    <summary>Enabled apps</summary>

 - activity: 2.5.2
 - admin_audit: 1.2.0
 - apporder: 0.4.0
 - audioplayer: 2.1.0
 - bookmarks: 0.10.1
 - calendar: 1.5.5
 - checksum: 0.3.5
 - comments: 1.2.0
 - contacts: 1.5.3
 - dav: 1.3.0
 - deck: 0.2.2
 - encryption: 1.6.0
 - federatedfilesharing: 1.2.0
 - federation: 1.2.0
 - files: 1.7.2
 - files_automatedtagging: 1.2.2
 - files_external: 1.3.0
 - files_opds: 0.8.2
 - files_pdfviewer: 1.1.1
 - files_reader: 1.0.4
 - files_sharing: 1.4.0
 - files_texteditor: 2.4.1
 - files_trashbin: 1.2.0
 - files_versions: 1.5.0
 - files_videoplayer: 1.1.0
 - firstrunwizard: 2.1
 - gallery: 17.0.0
 - gpxedit: 0.0.7
 - gpxmotion: 0.0.5
 - gpxpod: 2.2.0
 - issuetemplate: 0.2.2
 - logreader: 2.0.0
 - lookup_server_connector: 1.0.0
 - metadata: 0.5.0
 - news: 11.0.5
 - nextcloud_announcements: 1.1
 - notes: 2.3.1
 - notifications: 2.0.0
 - oauth2: 1.0.5
 - ownpad: 0.5.10
 - password_policy: 1.2.2
 - previewgenerator: 1.0.6
 - provisioning_api: 1.2.0
 - qownnotesapi: 17.5.0
 - rainloop: 5.0.2
 - serverinfo: 1.2.0
 - sharebymail: 1.2.0
 - spreed: 2.0.1
 - survey_client: 1.0.0
 - systemtags: 1.2.0
 - tasks: 0.9.5
 - theming: 1.3.0
 - twofactor_backupcodes: 1.1.1
 - updatenotification: 1.2.0
 - workflowengine: 1.2.0

 - dashboard
 - spreedme
 - user_external
 - user_ldap

{
    "instanceid": "ocl3mzv8sorh",
    "passwordsalt": "***REMOVED SENSITIVE VALUE***",
    "secret": "***REMOVED SENSITIVE VALUE***",
    "trusted_domains": [
        "localhost",
        "oc.********.nl"
    ],
    "datadirectory": "\/mnt\/owncloud\/owncloud",
    "overwrite.cli.url": "oc.**********.nl",
    "dbtype": "mysql",
    "version": "12.0.2.0",
    "logtimezone": "UTC",
    "installed": true,
    "memcache.local": "\\OC\\Memcache\\APCu",
    "loglevel": 0,
    "defaultapp": "apporder",
    "knowledgebaseenabled": "true",
    "custom_csp_policy": "default-src 'self'; script-src 'self' 'unsafe-inline' 'unsafe-eval'; style-src 'self' 'unsafe-inline' data: blob:; frame-src *; img-src *; font-src 'self' data: blob:; media-src *",
    "maintenance": false,
    "dbname": "ocdatabase",
    "dbhost": "127.0.0.1",
    "dbuser": "***REMOVED SENSITIVE VALUE***",
    "dbpassword": "***REMOVED SENSITIVE VALUE***",
    "theme": "",
    "data-fingerprint": "ab51ae68f88b0d5df560447d24ce885f",
    "mail_from_address": "oc",
    "mail_smtpmode": "smtp",
    "mail_domain": "linuxpete.nl",
    "mail_smtpauthtype": "LOGIN",
    "mail_smtphost": "mail.***********.nl",
    "mail_smtpauth": 1,
    "mail_smtpport": "465",
    "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
    "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpsecure": "ssl",
    "enabledPreviewProviders": [
        "OC\\Preview\\Image",
        "OC\\Preview\\MP3",
        "OC\\Preview\\TXT",
        "OC\\Preview\\MarkDown",
        "OC\\Preview\\Epub",
        "OC\\Preview\\PDF",
        "OC\\Preview\\OpenDocument",
        "OC\\Preview\\StarOffice",
        "OC\\Preview\\MSOfficeDoc",
        "OC\\Preview\\MSOffice2003",
        "OC\\Preview\\MSOffice2007",
        "OC\\Preview\\FB2"
    ],
    "mysql.utf8mb4": true
}

Client configuration

Browser: IE 11

Operating system: Windows 7, 8

Logs

Insert your webserver log here

Insert your Nextcloud log here

Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log
c) ...

I noticed that app order is not working as it should when you have more then 7 apps enabled. With nextcloud12 the "..." (more apps) icon has been introduced. When moving the apps displayed on the main top bar, everything works as expected. But if you start moving apps that are in "More aps" section, apporder goes crazy and starts putting apps in random order (not set by admin, nor the user). The only way to fix it is to put order accordingly to what is being set by apporder atm, and only then manually more apps around, but only the main 7.

The app is quite popular but could do with a screenshot or better yet a gif to add to the readme and the app store listing. ;)

https://apps.nextcloud.com/apps/apporder

@juliushaertl

Hi,

i just downloaded and installed apporder 0.3 in NC 10.0 and installed a test user.
After login of the test user nothing was seen of the apporder menu in the left bar, however, it showed up twice in the admin account (see enclosed screenshot)!

regards, hitam 4450

Hi,
can you please make a update where be able to be listen
in Nextcloud 12 again ?
properly it is not listed, because the needed max-version of your app to nextcloud.
thank you :)

best regards
blacky

Hi,
Your app is not just about the app order, but gives the ability to make an app visible or not.
I didn't notice that as the title of your app doesn't imply that, so does your app have the right title?

But i think its a great extra feature, it's worth to mention it in the app info and in the store I guess.
Some users would want to disable apps from their view if they don't use them, although they are installed.

When the width of the browser window reaches a small app icons are nested in a more apps icon (see screenshot). It would be a nice feature if AppOrder could customize this behavior too, not depending on the window width. Further, when the width gets small, the remaining apps could be gradually absorbed in the more apps icon.

Some suggestions for the AppOrder menu:

1. the apps unchecked are nested (instead of invisible); or
2. there could be a separator which could be moved around like the other apps, and items beneath this separator would be nested.

Hi,

Small feature requests:

1/ Modifying the default number of apps
Could it be possible to change the default maximum number of app display in the top - and not just the order?

For now, default behavior is to fold apps into a dropdown after it's reached 9 apps in the top.
It'd be great if we could modify the number of the app as well.

For now this can be done only my modifying the core :
in ../nextcloud/core/js/js.js
var minAppsDesktop = 8;

Altering this number would change the current behavior on desktop (which is mainly where I think it would be useful).

Changing the core would not be a smart idea - and it make sense to me this would be a part of the apporder application - which is already heping customizing how app are behaving.

2/ Changing default app
While I know this can be changed in the config file, it seems to me it would make sense if it would be a part of the app as well.

I want to force the app order I set in the admin settings. Is this possible yet?

Hi, I installed in NC 10.0 apporder 0.32. I set the calendar app as landing page in amin panel ( first in the line of apps in direct_menu ) however files app shows up as landing page at login!

Login as user ---still the files app show as up as landing page, despite I rearrange it for test purposes to be the audioplayer! No menu item given in user panel to rearrange!

regards, hitam4450

Undefined index: at /home/www/pr0npaganda.net/cloud/nextcloud/apps/apporder/controller/settingscontroller.php#53

Installed Collabora and then removed Documents left some empty entries in the Apps list. Added a fast in_array in your function to stop flooding my logs (and having empty icons in the listing in the admin page.

53c53,56
<             $result[$app] = $nav_tmp[$app];

---
>       {
>             if (in_array($app, $nav_tmp))
>             $result[$app] = $nav_tmp[$app];
>       }

to avoid stretched images

On NextCloud 12.0.0, I was successfully able to modify the standard default menu. It was globally applied, and works on initial login, but seems to reset itself within a session. Also, I had to manually update the config file with the apporder.

Hi,

Thanks for this app really useful :-)

May you please make an update to be compatible with Nextcloud 12 ?

Best Regards

I installed version 0.1.1 and tried the app. The order of apps in the direct menu will be only updated after a refresh of the page! How about an automated refresh e.g. with small time laps, to update e.g. the order of apps in direct menu??

regards, hitam4450

As javascript is used to reorder the icons, the icons are jumping when the page loading is slow.

Hi,
I like your app and I can not wait for NC12 support, so I have tried to use the last version from gitbub.
I have downloaded it to my server to folder apps. Then I have removed old version 0.33. Next I wanted to enable it but such error has occured:

Is it possible to use version 0.4 with NC12? What should I do to enable (and use) it?

Best regards!

The icon for the apporder app doesn't show on the personal setting page.

AppOrder 0.3.2 & 0.3.3 forces constantly reloading the website if user is not authenticated/anonymous.

This is an rare situation but can be easily rebuild when using the polls app and creating an public link to an poll.

More Info?
Please check the original bug-report that was created for the polls app:
nextcloud/polls#96 (comment)

I just installed the new Version 0.1.2 on OC 9.0.4 which resulted in the following error message (See enclosed screenshot)

regards, hitam4450

On every reload the admin panel shows the app order coming from owncloud, it sould be sorted as saved inside the app.

I edited my config.php to have "apporder" as default app and then moved the news app in first place.
However after a while I decided to not use the news app anylonger and removed it.

The problem is that users still get redirected to the now non-existing news app on login.

Better would be if apporder would fail to the second used app in the list.

The app doesn't work with Nextcloud 14, yet.

Original report: nextcloud/server#11382

It seems that all files use tabs, except template/admin.php, should it be changed to use tabs?

Hi!

We use Nextcloud 13 and the latest apporder app. Following scenario:

• We set a default order (1. mail, 2. calendar, etc.) to all apps and set 'defaultapp' => 'apporder', in config.php
• After, we limit the first app (e.g. mail) in app order to a group (e.g. groupware)
• Logging in with a user that is not part of the group groupware redirects the user to app mail, but the app is not allowed. Redirect fails.

Proposal

• apporder should fallback to the next available app in app order list and redirect to that app.

Nice little app - should be integrated into Nextcloud core codebase IMO.

It would be nice to see the option to explicitly specify an app as the default page on login - rather than assuming the first on the list. It would be extra extra cool to for Pico CMS app users to be able to specify a Pico page as the default, instead of an app. This would enable Nextcloud admins to create a customised welcome page that users hit when they login. As a simple html redirect it should be super easy to implement.

When sorting icons in the owncloud standard menu, an additional padding seems to be added to the menu.

Hi,

to avoid any comments, bad remarks, confusion, etc. about the functionality of the app, it should be most advisable, to make the apporder the default app in config.php at installation, resp. enabling, automatically!

regards, hitam4450

This app is awesome! Adding possibility for users to sort app order is great. Would it be possible to be able to hide apps? I use quite some apps on my nextcloud instance and I know for a fact some of the apps are never used by some users.
My idea is to be able to hide the ones unused. Maybe could change the state to hidden when dragging the app onto "hide icon"?

When using the direct_menu app the name of the currently active app should stay in position.

Steps to Reproduce
1. Attempt to drag and drop an app icon in the direct menu / App Order menu to re-organize
2. Look under administrative settings for personalization of the menu

Expected behaviour
Applications icons can be re-ordered
Menu can be personalized to re-order or hide icons

Actual behaviour
Nothing changes. No personalization is available.

The order doesn't stick when using the Direct Menu app (which shows icons along the top rather than in the drop-down corner menu - thus saving time when working).
https://apps.owncloud.com/content/show.php/Direct+Menu?content=169148

When an app is removed it should not be visible in the app list for the default order.

No icons are shown when there is no default order defined.

As jquery-ui may get removed from core, we should include the source into this app.

owncloud/core#18739

AppOrder is working well with Microsoft Edge, with Chome and some other Browser ..

but NOT WITH INTERNET EXPLORER 11.

The whole APP Column will disappear and many users are affected, which are not able to work anymore with their apps ..

Support appreciated.

General server configuration

Operating system: FreeBSD Nextcloud 11.0-RELEASE FreeBSD 11.0-STABLE #0 r321665+25fe8ba8d06(freenas/11.0-stable): Mon Sep 25 06:24:11 UTC 2017 root@gauntlet:/freenas-11-releng/freenas/_BE/objs/freenas-11-releng/freenas/_BE/os/sys/FreeNAS.amd64 amd64

Web server: Apache/2.4.27 (FreeBSD) OpenSSL/1.0.2j-freebsd PHP/7.0.21 (apache2handler)

Database: mysql 10.2.7

Nextcloud configuration

Nextcloud version: 12.0.3 - 12.0.3.3

PHP version: 7.0.21

Cheers
Mike

As the admin, I have set a custom order for the entire installation, but it doesn't reflect on my own order. Apparently, I have previously set a personal custom order. I would like to reset it, so I too can use the global custom order.

Additionally, I am not entirely sure, if I actually changed my personal order at all or if there is a bug hiding there. But another time, another issue :-)