GithubHelp home page GithubHelp logo

juntossomosmais / atomium Goto Github PK

View Code? Open in Web Editor NEW
158.0 13.0 6.0 398.59 MB

Atomium is an internal design system for 'Juntos Somos Mais' using Web Components

Home Page: https://juntossomosmais.github.io/atomium/

License: MIT License

Shell 0.05% JavaScript 1.33% TypeScript 69.01% SCSS 12.44% HTML 0.20% CSS 0.30% MDX 16.67%
custom-elements design-system ionic stenciljs web-components webcomponents nx storybook typescript design-systems

atomium's People

Contributors

3rdepaula avatar denilsonrp avatar dependabot[bot] avatar felipefialho avatar gabrielduete avatar github-actions[bot] avatar igorwessel avatar jowjow22 avatar juliocvaz avatar lucasgomestl avatar luiz-ortega avatar lupy100 avatar matheus-rosa-jsm avatar matheusgeiger avatar mauriciomutte avatar mayararma avatar rodrigorvsn avatar sallescosta avatar schirrel avatar tassiofront avatar vmcustodio avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

atomium's Issues

Loading Button is enabled

Current behavior

  • Atomium Button when in Loading state, is enabled

Expected behavior

  • Atomium Button being disabled when loading

How to reproduce

Code example

import React from 'react'

import { AtomButton } from '@juntossomosmais/atomium/react'

export default function Teste() {
  return (
    <>
      <AtomButton loading onClick={() => console.log('LOADING CLICK')}>
        Loading
      </AtomButton>

      <AtomButton disabled onClick={() => console.log('DISABLED CLICK')}>
        Disabled
      </AtomButton>

      <AtomButton onClick={() => console.log('NORMAL CLICK')}>
        Normal
      </AtomButton>
    </>
  )
}

Video example

loading-button.webm

bug: Stencil and Jest problem with dependancies that have exports on package.json

This issue is an live issue for us to keep track and an eye on the problem around package.json property exports with both Stencil and Jest

Context

While development of the Carousel Component(#235) we have discover a problem when using Swiper on the project.

Details

Swiper package.json uses the export property to export diferent modules inside the lib
We discovered this is as issue with stencil itself, once while trying to use like explained on Swiper docs we recieve the below error while building and starting the project:

[ WARN ] Bundling Warning UNRESOLVED_IMPORT
'swiper/element/bundle' is imported by src/components/my-component/my-component.tsx, but could not be
resolved โ€“ treating it as an external dependency

We opened the issue ionic-team/stencil#4660 on stencil's repository, and was informed to create a thread on the support discord channel.

We manage to be able to use Swiper with Stencil by change the way we import, from:

import { register } from 'swiper/element/bundle';
register();

to

import 'swiper/swiper-element-bundle.js';

This way Swiper register the custom element automaticaly using an IIFE.

Jest

We also discovered this to be an issue with Jest once our current version of jest doesn't support this property current. (jestjs/jest#9771 (comment))
This already had been reported on swipers oficial repository:

Even we had manage to work with Swiper on the element itself, we had trouble using it with stencil test suit .
In order to register a web component within the test Mock DOM we are required to pass it through components property inside the newSpecPage , but once we cant named import things from Swiper, it can anchieve full coverege on Swiper events, for exemple.

You can see that the PR's coverage is below the required only because of the three lines of the on functions.

BUG - Component inside carousel item is not interactible or keep it usual behavior

While implementing carousing within Loja Virtual, we face the issue of the Card componing looses its "connectin" with the framework. Stops to be interactible and reactive, stops to update values and other items, see the video below:

Gravacao.de.Tela.2023-09-14.as.12.19.15.mov

PS. I already uunderstood whats is going on and am current working on it, on the next hours i will open the PR fixint it ๐Ÿ™๐Ÿป

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.