jurassix / atom-javascript-refactor Goto Github PK

This throws an error at the moveSync() call in renameFile(). Ideally it would merge the directory contents.

We might be able to use this - https://github.com/binocarlos/merge-dirs

We need test coverage for 1.0 release.

It's a node builtin

jurassix/refactoring-codemods#1

The "codemods" bit is arguably an implementation detail, and the "atom" bit could probably be dropped. Looking through my extensions, about half use the "atom-" prefix, so we could go either way.

Or somewhere

Hi,

Just installed the plugin, I added vue to the file extensions, so:

but nothing happens when I move a file. Maybe Vue is not supported?

Best Regards,

Francesco Saverio

This is output to the console on an npm install:

npm WARN deprecated [email protected]: eslint-plugin-flow-vars has been deprecated in favor of [email protected] or higher

Depending on where you right click on a file or directory in the tree view to open the context menu, sometimes the refactor handler event.target is the element with the [data-path] attribute, and sometimes it is a parent element, up to and including the .file or .directory element specified in menus/atom-javascript-refactor.json.

To reproduce, right-click as far to the left as possible on a file entry. event.target will be the parent list item.

I'm not sure if this is an atom bug or expected behavior, but we can work around it by finding the first child with a [data-path] attribute if the event.target does not have one.

Currently we serially apply the releative transform this needs to be updated to support a batch mode so we only call it once on the project.

Another possible performance optimization is to combine the import and releative transforms into a single transform that is called once on the project per rename. This significantly increased complexity of the transform, and makes it a very niche transform. But would be worth the complexity to only traverse/transform to AST/apply mods to the project structure once.

Finally we need a proper test that scaffolds a large file base and run the transforms on these as a baseline.

refactor does not work

I'm seeing an when triaging #65 where changes to Ignore Config or Ignore Pattern are requiring me to reload Atom for my Package to pick up these changes. More research is needed to determine how to resolve.

Running Atom 1.22.1

The resolve algo used by node/browserify/webpack allow js files to require/import .json files without including the extension. When moving a .json file, or file that references a .json file, the path to the json file should be updated.

When you import a file by directory that contains an index.js file, and you rename the index.js file, references to it don't get updated.

Take the following example. Here's what the directory structure looks like before the refactor:

src/
  components/
    MyComponent.js (this file imports from "./propTypes")
    propTypes/
      index.js

If you rename /components/propTypes/index.js to /utils/propTypes.js, it will not update the MyComponent.js file to import from the new location.

Directory Structure after refactor:

src/
  components/
    MyComponent.js (this file imports from "./propTypes")
  utils/
    propTypes.js

Import String before refactor:

import * as propTypes from './propTypes';

Expected import string after refactor:

import * as propTypes from '../utils/propTypes';

Actual import string after refactor: (same as before refactor)

import * as propTypes from './propTypes';

It includes the AtomInput component that we already use, and a Spinner component that we may be able to use in the StatusBarTileComponent.

https://www.npmjs.com/package/nuclide-commons-ui

After right-clicking on a file and choosing "Rename (with refactor support)", nothing happens. The dialog box where it asks for the new name does not come up.

This stopped working recently (like a few weeks ago).

No errors in the dev console either 😭

This is kinda annoying, I'd love if it just used regular slashes!

Show a panel with all refactors possible let user select/deselect files to update

Hi,

I tried this package after installing it directly from Atom packages manager.
I have a file User.jsx with the following content :
import api from './Api';

From rename with refactor Atom menu, I renamed my Api.jsx file into Api2.jsx but the content of User.jsx file is not changed :-(

I tried after changing file format settings of package (js to jsx), but same result, no change.

Can you help me with this issue?

Hey @jurassix ,

I know we talked a while back on some thread about adding this to sublime and you said you were more interested in adding it to vscode. I'm using vscode now and would love to have this plugin there :)

Lemme know how I can help!

I think it broke when the repo was renamed. Nuclide has an update but there is no pull request from greenkeeper.

If the file is open in text editor it seems transform changes applied are reverted. Some kind of atom cache or git cache issue is happening - i think. Need to research tree-view move-dialog and rename functions to see what subtleties are missing in our implementation

We'll probably want better test coverage before we do this. Greenkeeper runs tests when bumping dependencies and will tell you if the new version broke anything.

see this issue.
reference: jurassix/refactoring-codemods#2

Does this module support moving functions from one file to another? If not, would there be any interest in a PR for this functionality?

What runner do we want to use? My vote would be for ava or jest. Both can run tests in parallel. I've never used jest so I'd probably just stick with ava.

[Enter steps to reproduce:]

1. ...
2. ...

Atom: 1.21.1 x64
Electron: 1.6.15
OS: Mac OS X 10.12.6
Thrown From: javascript-refactor package 0.5.7

Stack Trace

Uncaught TypeError: q.drain is not a function

At /Users/nadiacarvalho/.atom/packages/javascript-refactor/node_modules/async/lib/async.js:909

TypeError: q.drain is not a function
    at /packages/javascript-refactor/node_modules/async/lib/async.js:909:23
    at /packages/javascript-refactor/node_modules/async/lib/async.js:44:16
    at /packages/javascript-refactor/node_modules/fs-plus/lib/fs-plus.js:438:24
    at FSReqWrap.oncomplete (fs.js:112:15)

Commands

     -0:43.8.0 core:save (input.hidden-input)
     -0:40.6.0 core:paste (input.hidden-input)
     -0:39.5.0 core:undo (input.hidden-input)
     -0:38.6.0 core:save (input.hidden-input)
     -0:27.1.0 tree-view:remove (span.name.icon.icon-file-directory)
     -0:15 remote-sync:configure (span.name.icon.icon-file-directory)
     -0:05.5.0 remote-sync:upload-folder (div.header.list-item)

Non-Core Packages

atom-beautify 0.30.5 
atom-clock 0.1.15 
atom-javascript-console-snippets 0.10.0 
atomify 0.6.0 
chestnut-light-atom-syntax 0.2.1 
es6-javascript 1.0.0 
format-javascript-comment 0.2.5 
gcc-make-run 0.2.12 
gpp-compiler 3.0.7 
javascript-object-snippets 0.3.0 
javascript-refactor 0.5.7 
javascript-snippets 1.2.1 
javascript-standard-snippets 0.2.1 
language-javascript-better 1.7.1 
language-javascript-jxa 0.2.8 
language-javascript-subtlegradient 0.1.0 
min-ui 0.0.4 
qolor 0.4.2 
remote-sync 4.1.6 
turbo-javascript 1.4.0 
zooce-syntax 1.0.1 

We need to clean up the README.md to be clear about what this atom package does. The README.md is visiable in: Atom Settings > Packages, APM, and GitHub. Language should be simple and informational.

We also need a visual demo. I'm inclined to use a GIF but they are quite large. it would be nice to have audio too. I'm thinking a DEMO video would be good, hosted on YouTube.

After this issue is closed we should spread the word to Facebook members, especially the ones interested in codemods, to get some feedback/critique of this.

create-react-app bootstraps css support loaded from JavaScript; JS files have import statements to .css files. We need to update our JS files if these move.

Coveralls seems popular. Anything else worth looking at?

cc @spudly @jurassix

The default Rename command does this, so we can use that as an example.

If we add a small abstraction on top of our JavaScript rename + codemod transforms, then potentially we could support other file formats in the future if we wanted. Might even be worth moving the JS strategy into a separate project and inject it here...Or at least provide a way to inject others and have this be the 'native' implementation.

The flow-typed repo already has a complete libdef for redux. However, a few of our source files need to reference redux types (like Store), and it is not yet possible to import types from a module declaration.

Blocked by flow-typed/flow-typed#16

When I am processing a refactor ("Refactor in progress..." in the stats bar) with this package, I am seeing Atom Helper take 100% of one of my CPU cores. It can also take a couple of minutes to process on a new 5K retina imac with 32gb of RAM.

My project is mid-sized, so I'm not sure what the issue is. Maybe it is going into node_modules for some reason? Could there be a way to limit the scope of the refactor?