justinhunt / moodle-assignsubmission_cloudpoodll Goto Github PK

https://github.com/justinhunt/moodle-assignsubmission_cloudpoodll/blob/master/classes/utils.php#L117

Moodle has an internal curl class that deals with moodle sitting behind a web proxy etc.

It looks like the line below is appending ggggg to the text. Is that intentional or should that line be changed?

https://github.com/justinhunt/moodle-assignsubmission_cloudpoodll/blob/master/locallib.php#L409

Thanks for the awesome plugins!
-Jesse

assignsubmission_cloudpoodll crashes the tool_dataprivacy\task\process_data_request_task adhoc task because it defines a _delete_submissions function instead of delete_submissions (No underscore). I've fixed this on my system by adding the following to mod/assign/submission/cloudpoodll/classes/privacy/provider.php:

public static function delete_submissions(assign_plugin_request_data  $deletedata) {
    $this->_delete_submissions($deletedata);
}

DB functions should be hard-coding the table names - not pulling in the name of the table from a constant.
This is unnecessary abstraction and makes it hard to review your code - table names are a source of possible sql injection.
eg: