juvojustin / juvo-mail-editor Goto Github PK

Currently, the process works by receiving the email array of a fillter and basically nullifiying the content. Since required mail parameters are empty the email will not be sent. This leads to a lot of empty entries on smtp plugins that log emails as well as some fatal errors if the sending plugin does not handle empty recipients correctly.

The (hopefully) solution

The best option we have is to keep the logic to hook into the filter but to fully discard the original mail using e.g. pre_wp_mail with a return of null. Ideally there is a solution we can keep the values of the original email and reuse them as defaults. This way, the default mail values of WordPress will also not be duplicated into the plugin.

Add the password_changed mailing again: https://github.com/JUVOJustin/juvo-mail-editor/blob/0c47f11d692193172a79f64611175167c78bd190/src/Mail_Editor.php

Filter: https://developer.wordpress.org/reference/hooks/password_change_email/

Should behave like "New_User"

Allow adding a global mail template. The goal is not to allow frontend editing of a mail template, but to add static HTML or twig code that will enclose the message.

Best would be to use a variable to pass to the template, and it should be filled by the "message" in the wp_mail hook.

• Add section in optionspage to add twig with content block reference
• Add checkbox to disable global templating
• Live rendered preview by ajax

Introduce a filter that allows adding custom cmb2 fields to a mail template.

Parameters:

• $cmb2 -> Meta Box

Add more complex context. Allow placeholders to contain object properties by including this symfony library: https://symfony.com/doc/current/components/property_access.html

This could allow dynamically adding any user or post data.

Workflow like in Password_Reset.php

• Title
• Triggers
• Subject
• Author
• Date

Completely disable mail sending for triggers blocked in the option

Add sandbox mode for untrusted content

• Dev Docs: https://twig.symfony.com/doc/2.x/api.html#sandbox-extension
• Example for loading Sandbox Extension: https://stackoverflow.com/questions/62517361/how-do-i-add-the-sandbox-extension-for-twig-in-the-timber-wordpress-plugin

Placeholder needs to be Uppercase

• Add switch language in Relay->sendMails ()

$switched_locale = switch_to_locale( get_locale() );
do_your_stuff();
if ( $switched_locale ) {
    restore_previous_locale();
}

• Determine language either by recipient. Maybe use context for easier handling.
• Add fallback if recipient language could not be determined
• Add a way to store callbacks in default_subject and default_message. This way the callbacks are called dynamically which allows wordpress default contents to be in any language. Right now they are stored statically in the site language

• Add Metabox
• Add action callback

Post Type

Posts will be used to set the content of a mail

• Register custom post type
• Use Gutenberg for mail editing and limit blocks
• Add CMB2 field to control active state

Mail Triggers

• Create taxonomy "mail_triggers" to add terms to.
• Introduce filter to easily allow developers to add new triggers
• Add default mail contents to term as custom field
• Create templates for default mail situations but disable them by default

Currently triggers are only added but not delted if they no longer exist.

Blocks are limited for all post types. The post context need to be checked

Some mails are already processed by buddyboss. Simply filtering for at the beginning of the message should do the trick

Change indicator to show an arrow down if row is open and an arrow-left of the group is closed. Try if usability is better if the row is open by default

WSForms has well documented hooks that can be used to set headers, content and modify the email

Currently, the trigger is executed for every rest_insert_user call. The callback does not check if it is an update or a creation.

https://developer.wordpress.org/reference/hooks/rest_insert_user/

Once a user requests a password change, the user receives two mails.

This is because https://github.com/JUVOJustin/juvo-mail-editor/blob/master/src/Mails/Password_Reset.php and https://github.com/JUVOJustin/juvo-mail-editor/blob/master/src/Mails/Password_Changed_Admin.php share the same emailArrayHook