GithubHelp home page GithubHelp logo

jverdi / jvalertcontroller Goto Github PK

View Code? Open in Web Editor NEW
17.0 17.0 2.0 516 KB

JVAlertController is an API-compatible backport of UIAlertController for iOS 7

License: MIT License

Objective-C 99.13% C++ 0.58% Ruby 0.29%

jvalertcontroller's People

Contributors

joe-tam avatar jverdi avatar nros avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

Forkers

mohsinka bchon

jvalertcontroller's Issues

[feature] MRC (manual reference counting) compatibility would be great

This backport of UIAlertController really is a life-saver. At least it was to me! Many thanks for your great work!

Unfortunately I have to maintain a legacy app that still uses MRC instead of ARC. Until April 2015 the app still supported iOS4 for iPad1. iOS4 does not provide ARC.

So I need a version of this library to cope with MRC and tried to implement it properly but keeping the impact as low as possible. I had to reorganize some code, though, which made it a bit more complex.
Please review my changes. I would be grateful if you could include my patch for others with the same problem.

implement iOS 5 support

iPad 1 not to be forgotten ...

current state of iPad 1 devices

All iPad 1 are stuck with iOS 5. They'll never get an update to any newer iOS.
It would be great to have iOS 5 support with JVAlertController and I am working on it.

iOS compatibility is partly working on developer machine

In fact, I managed to run the code on iOS 5 and implement the look of the UIActionSheet within a popover.

I'll prepare everything for a pull request.

new branch wanted for legacy iOS SDK?

Unfortunately my iPad 1 broke couple of weeks ago, so I have to rely on the iOS simulator, which I have to run on OSX 10.7 with Xcode4, because there is no iOS5 simulator available anymore on modern OS X or modern Xcode.

Because of the old simulator I have to compile with an old iOS SDK (<= 6) which lacks some protocols and classes involved. I managed to add everything that is needed to run JVAlertController and store all these things inside a sub-directory "legacy-iOS-SDK".

Do you prefer to put changes necessary solely to compile with legacy iOS SDK in a separate branch? IMHO legacy iOS SDK support is vital to test for iPad 1 with iOS 5 simulator, so it would be nice to include it in the main branch. These back ported files will hardly change in the future.

what is working

  • At the moment I concentrated to mimic the UIActionSheet displayed in a popover. This works from iOS 5 to iOS 8 with proper look!

what is not working

  • tint color is not working on iOS 5/6. A custom background image would be needed to implement that reliable - I think we can live without it :)

what is missing

  • AlertView is still work in progress
  • I will have to add a separate Xcode4 project settings file for testing everything on iOS5 simulator.

Swift support

Have anyone managed to run this library in mixed Obj-C/Swift project? Even though I imported all headers from JVAlertController pod in Bridging-Header, app still crashes when I want to instantiate UIAlertController in Swift code on iOS7.
It works perfectly when I want to use it in Obj-C part of project.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.