jwbuurlage / bulk Goto Github PK

Hi,

Thank you for making this great software package! While I was searching through my directories, ripgrep complained that the .gitignore file is malformed:

line 1: error parsing glob '**.swp': invalid use of **; must be one path component

Should it not be *.swp?

Seeing the source comment on World::sync, it is clear that it is intended behaviour for World::sync to clear message queues, but this was unexpected for me. I searched the web documentation but couldn't find that behaviour made explicit (but I admin I didn't reread all documentation).

As the documentation for queue describes it as an inbox, maybe it makes more sense to consume messages by iterating over them? (Unfortunately, I don't know whether side effects for iterators as implemented in C++ are idiomatic...)

For context: I now have two supersteps sending messages intended for the third superstep, so without commenting out the queue clearing in World::sync and exposing the queue implementation's clear method, I would have to manually buffer the messages in the second superstep.

I think you intend to use the block_partition initialized in line 40, if I'm not mistaken.
auto x = psc::vector<int>(world, block);