jwilm / pagerduty-rs Goto Github PK

Hi, just stumbled upon this from your blog post :) Just a minor note, if you want things to make as nice as possible, you may want to not restrict the string type to be the same when a function accepts multiple parameters:

    pub fn image<S>(src: S, href: Option<S>, alt: Option<S>) -> Context<'a>
        where S: Into<Cow<'a, str>>

should probably be

    pub fn image<S1, S2, S3>(src: S1, href: Option<S2>, alt: Option<S3>) -> Context<'a>
        where S1: Into<Cow<'a, str>>, S2: Into<Cow<'a, str>>, S3: Into<Cow<'a, str>>

(otherwise you're either only accepting all &str, or all String, but can't mix them)

The signature looks fairly ugly though, gotta give it that :)

👋 I'm interested in trying out this crate but it appears all the links to the docs are broken. Looks like maybe a redirect conflict with your blog perhaps? Thanks!