jwir3 / atom-over-and-back Goto Github PK

Steps to Reproduce:

1. Command+n to create a new file.
2. Type something into the new file (or cut-and-paste so you have multiple lines)
3. Navigate to another file.
4. Command+[ to navigate back to the untitled file.

Expected Results:

• ✅ Atom over and back navigates back to the untitled file you were previously working on.

Actual Results:

• ❌ Atom over and back navigates to a new untitled file.

We should add tests for the existing functionality in the package.

Right now, the following code:

    // We want to create a waypoint if this item represents a new file, or if
    // the distance between lines is > 5, but only if this wasn't triggered by
    // a navigation event.
    if (!self.currentWaypoint
        || self.currentWaypoint.fileName !== path
        || Math.abs(self.currentWaypoint.lineNumber - lineNo) > 5) {
      return true;
    }

ensures that waypoints aren't created unless they are > 5 lines away from the last waypoint. Instead of doing this, we should always create waypoints, but then coalesce based on the following algorithm:

   peek at the last waypoint
   if this newly created waypoint is adjacent to the last waypoint {
    pop the last waypoint
   }
   push the new waypoint

Right now, we don't have the ability to navigate after having edited the code. We should add code that correctly computes a waypoint after an editing operation has taken place.

If we migrate to Coffeescript, it might make things a little easier for us to understand how to use the Atom APIs when looking at their code (since it's in CS).

The package specs are a bit of a mess, with waitsForPromise() calls all over the place. It would be nice if we could refactor this so that some of these are not in this callback hell, and instead had a RxJava-like chain of things that could be completed before the test was done.

We need to be able to navigate within a file. So, when a user moves more than, say X lines, it should create a new waypoint.

We don't have any contributing information for new developers to get started. We should add this so that others can contribute to our source code.

Steps to Reproduce:

1. Use CMD+H to search for something globally. Notice that it performs the search.
2. Use over-and-back to navigate backwards.
3. Use CMD+H to search for something else globally.

Expected Results:

• The query is performed.

Actual Results:

• The search page for the first query is restored, even if it's been closed.

Steps to Reproduce:

1. Open Atom with a project that has some search term, x, you know is in the project.
2. Activate over-and-back.
3. Open up a project-wide search, using CMD+SHIFT+F
4. Search for your known search term, x.

Expected Results:

• Search results are displayed.

Actual Results:

• Search is always empty.

Steps to Reproduce:

1. Navigate to a file.
2. Edit a word on some line not at column 0 of that line.
3. Navigate to another file.
4. Navigate backwards using atom-over-and-back.

Expected Results:

• ✅ The original file (the edited one) should be reopened with the cursor position in the exact column and row it was left prior to navigating to another file location.

Actual Results:

• ❌ The original file is reopened with the cursor position in the correct row, but not the correct column.

Note this is filed as an enhancement, because over and back has never done this.

Once we move to Coffeescript (#6), we can probably use the same documentation generator that Atom uses for its API docs:

Normally, when clicking on a changed file in the git pane, opens a tab titled "Unstaged Changes", displaying a diff of the file.

When over-and-back is enabled, the tab opens if it's not open already but is never focused.