jystewart / theme_support Goto Github PK

The rails-2-3-support branch rake task for themes:cache:update is incorrectly calling the remove and create tasks:
task :update => [:theme_remove_cache, :theme_create_cache]

should be:
task :update => [:remove, :create]

Also, might be a good idea to move the tasks folder into the lib folder to avoid the deprecation warning in Rails 2.3.8:
DEPRECATION WARNING: Rake tasks in vendor/plugins/theme_support/tasks are deprecated. Use lib/tasks instead.

Thanks for an awesome plugin!

Theme_support doesn't work with Rails 3.

"vendor/plugins/theme_support/lib/patches/actioncontroller_ex.rb:35:in alias_method': undefined methodactive_layout' for class `ActionController::Base' (NameError)"

Theme_support is it still maintained ?

due to some SafeBuffer issue.

This plugin says it supports Rails 2.3, but requires .rhtml files (not .html.erb), etc.

I recently upgraded a Rails app from 1.x to 2.3.10, and upgraded the theme_support plugin to your version. However, I now get the following error. Any idea what's causing this?

can't convert Fixnum into String
vendor/plugins/theme_support/lib/patches/actionview_ex.rb:10:in `join'
vendor/plugins/theme_support/lib/patches/actionview_ex.rb:10:in `view_paths'
...

Also, what changes (if any) need to be made to the application to use this version of theme_support? Thanks!

ArgumentError (wrong number of arguments (2 for 1)):
/vendor/plugins/jystewart-theme_support/lib/patches/actioncontroller_ex.rb:61:in theme_support_active_layout' /vendor/plugins/jystewart-theme_support/lib/patches/actioncontroller_ex.rb:61:inactive_layout'
/var/lib/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/layout.rb:250:in pick_layout' /var/lib/gems/1.8/gems/actionpack-2.2.2/lib/action_controller/base.rb:879:inrender_without_benchmark'

This happens when an application starts to render the views..

See my question on StackOverflow. When I try to have Capistrano run the rake task to create the theme cache on deploy, the task successfully runs but Capistrano reports the copy commands as errors. This may have nothing to do with theme_support, but I thought I'd post here to see if you know what the issue is. Thanks!

Another minor one, but at the top it says:

 * Rake tasks are now namespaced, eg: "rake themes:cache:create" instead of "rake theme_create_cache"

But below it still lists rake tasks with their old names.