k0bus / creativemanager Goto Github PK

Describe the bug
CreativeManager can not run on Arclight.
I have reported to Arclight's author(IzzelAliz/Arclight#349)
but they said it was caused by plugin side.

https://paste.ubuntu.com/p/9H4wkzg3Wd/

My server is configured to teleport players who join to the spawnpoint and set their gamemode to Adventure. Even if, creative-inventory: true is set in the config, if a player who was in creative leaves the game, they get to keep their inventory when they join (I'm using WorldGuard to automatically set the gamemode when entering/exiting the creative mode area).

Protections: entity: true

A player is in creative mode, without a bypass permission.

When right-clicking on an entity, the message 'permission.entity' is sent, informing the player they cannot interact with it.

However, the player still managed to leash entities, ride entities, feed wolf and let them sit. They can even have access to entity containers such as chest minecart, llama and donkey.

Running minecraft 1.16.5, server core Paper.

Describe the bug
Players can retrieve items from creative back to survival using campfire.
They take the campfire and any item from creative, put an item on campfire, go back to survival and take the item.

To Reproduce
Steps to reproduce the behavior:

1. Place campfire
2. Take item from creative
3. Place item on campfire while in creative
4. Go back to survival
5. Take the item from campfire (there you have free items)

Expected behavior
Interaction disallowed with campfire

Screenshots
No need

Server informations:

• Spigot version: 1.19.3
• Java version: 17
• Plugin version

Hardware information :

• CPU: i7
• RAM: 14 GB
• Storage: SSD

User can destroy anothing from another player region.

PaperMC

Java 16

1.17.2

Xeno e2520v3 6/12

16 GB DDR4

240GB SSD/1 TB HDD

Describe the bug
An eventlistener of priority MONITOR should never modify the event. I found muliple instances where this was the case. Why does this matter? Because other plugins could also listen to the event at monitor priority. Modifying the event at the same priority means that there's a chance that those plugins recieve invalid input on what happened with the event.

To Reproduce
By looking into the code, I found this behavior in these following listeners:

• event.PlayerBreak
• event.PlayerInteractAtEntity
• event.PlayerInteractEntity

Expected behavior
Have those listeners be on a different priority

Screenshots
N/A

Server information:

• N/A

Hardware information :

• N/A

Smartphone (please complete the following information):

• N/A

Additional context

The player in the creative puts blocks such as:
Bed, picture, frame, boat, cart, armor rack.
Goes into survival mode and quietly gets these blocks when he breaks them.

• PaperMC

• Java 16

• 1.15

• Xeno e2520v3 6/12

• 16 GB DDR4

• 240GB SSD/1 TB HDD

code snippet:

Claim claim = GriefPrevention.instance.dataStore.getClaimAt(e.getBlock().getLocation(), false, (Claim) null);

if (claim == null) {
	Messages.sendMessageText(plugin.getMessageManager(), p, "You can't build on wilderness in creative mode");
	e.setCancelled(true);
} 

Describe the bug
When using "custom items" plugins combining with WorldGuard (unsure if that combination is required) the players can break blocks in protected world guard regions and in the unprotected regions they don't get any items.

To Reproduce
Steps to reproduce the behavior:

1. Create a region with build/break/passtrough deny
2. De-op yourself or make it so you're also denied to build/break blocks in that region.
3. Break a block

Expected behavior
For the break to not work

Screenshots
https://media.discordapp.net/attachments/718516051092176988/938887728223899709/unknown.png
Here is me using the command /wg debug testbreak <player>

Server informations:

• Spigot version (or another): Paper version git-Paper-182 (MC: 1.18.1) (Implementing API version 1.18.1-R0.1-SNAPSHOT) (Git: 2ec04e0)
• Java version: 17
• Plugin version: 1.19.1

Additional context
They also don't get items when breaking blocks outside protected regions.
Here is the list of the plugins:

Plugins (107): AdvancedGiveaways, AdvancedReplay*, ajLeaderboards, AnotherDailyBonus, AntiCheatReplay, AsyncWorldEdit, AuctionGUIPlus, AuthMe, Bank, BeehivesPro, BetterRTP, BKCommonLib, ChatFeelings, ChestSort, Citizens, CitizensBooks, CleanMOTD, CMI, CMILib, Codex, ConditionalEvents, Core, CoreProtect, CraftingStore, DecentHolograms, DeluxeCombat, DeluxeCombat_Addon_WG*, DeluxeMenus, DeluxeSellwands, DiscordSRV, eco, EcoArmor, EcoEnchants, EcoEnchantsGUI, EcoItems, EcoSkills, EpicFurnaces, EpicHoppers, ExcellentCrates, ExecutableBlocks, ExecutableItems, FarmControl, GSit, InteractionVisualizer, InteractiveChat, InteractiveChatDiscordSrvAddon, InventorySaver, ItemEdit, Jobs, Karma, KiteBoard, LastLoginAPI, LevelledMobs, LibsDisguises, LiteBans, LocketteX, LuckPerms, Matrix, MineTweaks, MoreDispenserUtilities, My_Worlds, MythicMobs, NametagEdit, NBTAPI, NexEngine, Oh_the_dungeons_youll_go, OreAnnouncer, Parties, PlaceholderAPI, PlayerShopGUIPlus, Playtime, PlugManX (PlugMan), ProtectionStones, ProtocolFirewall, ProtocolLib, PunishGUI, Quests, Reforges, RoseStacker, RPGHorses, SCore, ShopGUIPlus, Shopkeepers, SkinsRestorer, Skulls, sleep-most, SlimeMap, SlotMachine, spark, StatTrackers, SuperbVote, SuperVanish, Talismans, TempFly, TigerReports, TradeSystem, UltimateAutoRestart, UltimateKits, UltimateTimber, Vault, ViewDistanceTweaks, VoidGen, Votifier, Vouchers, VTitleAuth, WorldEdit, WorldGuard

I did removed CreativeManager and everythings works fine.

Describe the bug
My server.properties (papermc) has the force-gamemode=true and gamemode=survival. If within the game an op changes someone's gamemode to creative, and the user logs out and back in, the user's gamemode will be reset to survival.

This plugin doesn't detect this correctly and so the survival inventory gets wiped and the creative inventory gets copied as survival inventory.

To Reproduce
Steps to reproduce the behavior:

0. Server force-gamemode=true and gamemode=survival
1. User logs in
2. Op sets gamemode to creative
3. User logs out
4. User logs in
5. User's original survival inventory is wiped and he will instead have the creative inventory copied (without CM restrictions, because he'll be in survival) - blocks placed from the inventory can still be mined.

From the log, it looks like the server changes the gamemode right after the user disconnects, which is not correctly caught by the plugin.

Expected behavior
The change of gamemode between log-out and log-in is detected by the plugin, and correct inventory loaded.

Log

01.05 15:25:21 [Server] INFO Save inventory of user dblblaster in file fc5fea03-81c2-3ea5-8942-93293d0b7aed.yml for gamemode SURVIVAL
01.05 15:25:21 [Server] INFO Clear inventory for dblblaster (fc5fea03-81c2-3ea5-8942-93293d0b7aed) because no saved inventory found for gamemode CREATIVE
01.05 15:25:21 [Server] INFO Set dblblaster's game mode to Creative Mode
01.05 15:25:38 [Server] INFO Log saved to database ! [1]
01.05 15:26:16 [Disconnect] User dblblaster has disconnected, reason: Disconnected
01.05 15:26:16 [Server] INFO Save inventory of user dblblaster in file fc5fea03-81c2-3ea5-8942-93293d0b7aed.yml for gamemode CREATIVE
01.05 15:26:16 [Server] INFO dblblaster left the game
01.05 15:26:18 [Server] INFO UUID of player dblblaster is fc5fea03-81c2-3ea5-8942-93293d0b7aed
01.05 15:26:18 [Server] INFO Save inventory of user dblblaster in file fc5fea03-81c2-3ea5-8942-93293d0b7aed.yml for gamemode SURVIVAL
01.05 15:26:18 [Server] INFO Load inventory of user dblblaster in file fc5fea03-81c2-3ea5-8942-93293d0b7aed.yml for gamemode SURVIVAL
01.05 15:26:18 [Server] INFO Load inventory of user dblblaster in file fc5fea03-81c2-3ea5-8942-93293d0b7aed.yml for gamemode SURVIVAL
01.05 15:26:18 [Server] INFO dblblaster joined the game

Server informations:

• Spigot version (or another): PaperSpigot 1.18.2 (git-Paper-317)
• Java version: Java 17 (OpenJDK 64-Bit Server VM 17.0.1+12)
• Plugin version: 1.20.2

Describe the bug
After upgrade to latest version naturally generated items for non op gm 0 players won't drop anymore.
If you are op vereything is fine. After unload the plugin items dropped fine for all players.

To Reproduce
Upgrade to latest version and mine a block

Expected behavior
block should drop

Screenshots
If applicable, add screenshots to help explain your problem.

Server informations:
[10:40:17 INFO]: This server is running Paper version git-Paper-178 (MC: 1.18.1) (Implementing API version 1.18.1-R0.1-SNAPSHOT) (Git: 3109dd8)
Java 17
Your latest from Spigot

Hardware information :

• CPU
• 25GB for MC
• 800GB SSD

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22

Additional context
Add any other context about the problem here.

When trying to break a creative-placed block, instead of preventing to break it would be nice to just allow to break but don't drop any items.

Describe the bug
Enabling the container protection feature also doesn't allow me to change items in my admin shopkeeper made using https://www.spigotmc.org/resources/shopkeepers.80756/ btw it requires creative edit admin shopkeepers. I was hoping if you could detect this plugin in servers and stop the conflicts

To Reproduce
Steps to reproduce the behavior:

1. ... Install https://www.spigotmc.org/resources/%E2%9A%A1-creativemanager-%E2%9A%A1-customizable-complete-control.75097/
2. ... Install https://www.spigotmc.org/resources/shopkeepers.80756/
3. ... Install https://luckperms.net/
4. ... Create an admin shop using shopkeepers plugin
5. ... Deop your self and give perms for gamemode creative using luckperms
6. ... Make sure that Container protection is enabled in the config of CreativeManager
7. ... Shift-Right click the admin shopkeeper in creative to edit it

Expected behavior
admin Shopkeeper's editing gui should have normally opened

Screenshots

Server information:

• git-Paper-493 (MC: 1.20.4)
• Java version
• 1.35.3

Hardware information :

• 2
• 2600
• 4gb

Is your feature request related to a problem? Please describe.
Being able to set some items to one time use would then allow you to make that item purchasable in an in game store. An example would be spawn eggs and spawners.

Describe the solution you'd like
A way to set in the config, items that have a one time use these items will not be allowed to be obtainable in the creative menu. The items in this config category would disappear after one use (spawn eggs) placable items would be removed from your inventory when placing them and would return to your inventory when breaking them.

Describe alternatives you've considered
I have considered having someone make a plugin with just this feature.

Additional context
This feature would greatly enhance any creative server by allowing server owners to make some items only obtainable through a store, event or mini game. etc.

Bonjour,
J'utilise la dernière version du plugin qui est plutôt bien en soit je suis passé d'un autre à celui là sans soucis cepandant depuis quelque jours j'ai des lags assez énorme :

J'utilise la dernière version de paper.

Je vous remercie,

It would be nice to have a grouping system.
I would like to use the same inventory for adventure and survival modes.

An example config:

# gamemode: what-inventory-to-use
inventory:
  creative: creative
  adventure: survival
  survival: survival
# Instead of false: creative: ignore