kabouzeid / phonograph

A material designed music player for Android

Phonograph

A material designed local music player for Android.

phonograph's Issues

Replace the bus system with Intents

RemoteControlClient is deprecated

I believe there's a newer solution on Lollipop now.

Weird issue with grid items popping out while scrolling

The album art for the top right item popped out while I was scrolling and got stuck slightly below.

Integrate Cabinet's code for theming radio buttons and check boxes inside overflow menus

This requires a bit of reflection

Save the current queue and position in an SQL database to improve the performance (compare CM12's Eleven Music Player)

Display top tracks in the artist viewer, similar to Google Play Music

last.fm has a top tracks web service: http://www.last.fm/api/show/artist.getTopTracks

The artist viewer page could display an artist's top tracks and allow you to play them (or buy them via Google Play or whatever if they don't). It could be a configurable setting for those who don't want to see songs they don't have.

Fastscroller but without destroying the design

Scroll position for all main fragments should be persisted

When I come back to the app after playing music for a while, it will be at the top of the list. I think it's a better user experience to always stay at the same scroll position even after the Activity is killed and started again.

I also noticed that if you pause music, and come back to it after the app has been killed by the system, the playing position is lost. I believe Google Play Music remembers your scroll and play positions indefinitely.

Fastscroller scrolling in song and artist view is extremely laggy because the song list is huge in most cases. Replace by other implementation.

Visibility issues in album/artist detail and tag editor

You can't see the back button, now playing button, or overflow menu.

The seekbar in the now playing screen suddenly got some kind of padding or margin to the left and right which looks weird

I fixed that before by using the padding 0dp in v21/styles and setting margins to 0 in the activity. However those values no longer seems to take affect.

You have Volley, Ion, and OkHttp all as dependencies

Ion is capable of web requests, having both makes the size of the app quite a bit larger

The "add to queue" button in the multi-select cab menu seems to be grey instead of white on below Lollipop

Integrate butterknife into adapters and everywhere else where findViewById() is used

Fastscroller thumb gets hidden when scrolling down with the toolbar not collapsed

The thumb needs some spacing from the bottom with at least the height of the toolbar. The "line" where the thumb slides on should still go to the very bottom of the screen to keep it looking good.

Best spacing would probably be the fab_activity offset dimen which is also used for the content the fastscroller scrolls here.

An alternative to try would be to place the fastscroller inside the main activity layout and align it to below toolbar and the bottom of the screen.

What exactly does the playback controller card setting do?

It doesn't seem to affect anything

After deleting a song the playing queue gets messed up. Most of the times the current playing song info then doesn't match the actual playing song.

Last.fm scrobbling stopped working somehow

If you delete a song from an album or artist, and it's the last remaining song, the activity should be closed afterwards. If it's not the last, it should be removed from the list in the album detail view.

Note: RecyclerView.Adapter has methods to update, insert, or remove individual items since notifyDataSetChanged() is rather intensive.

Recently played and thumbs up auto playlists?

The app could have a 'like'/'favorite' system, similar to Google Play Music. When you tap a thumbs up in the now playing screen, it would add the song to a playlist and display the thumbs up icon with the accent color.

There could also be a playlist that displays the last 100 or so played songs.

Add a sleep timer

Big performance issue with the new way of setting statusBar color in album and artist detail activity

Ripples need some polishment

1. flickering
2. hardly noticeable in dark theme
3. when clicking an album it "flashes" up for a moment - creates visual noise

Completely rewrite the playing queue

The current implementation, with the dialog, is more or less a placeholder.

Weird issue with the FAB icon being off center

It doesn't seem to happen in the main activity, only in the artist and album viewer, and in the now playing screen.

Tag editor should use the same colors generated for an artist or album palette

Just because it would look cool.

It will get passed through the intent to the tag editor activity.

FAB is too close to list content in album **and** artist detail screens

More widget sizes

MusicService class needs some clean up.

EditText in Material Dialog no longer tinted

@afollestad I am sure you know how to fix that :D

To fix tomorrow: FAB is too far down (fitsSystemWindows on drawer layout is messing with it, status bar color on KitKat is wrong in artist/album detail screens

Allow persistent notification to be swiped away when music is not playing

Similar to Play Music

Using translucent status bar on Lollipop tints it darker than it should be

I know it's important to use translucentStatusBar to allow this style of UI to work on KitKat, but on Lollipop you should be using only the statusBarColor along with DrawerLayout#setStatusBarBackgroundColor so that the status bar color is exactly what is specified by themes.

With new image loader (Glide) there are problems with the diskcache: It does not update when the album art changes.

I will fix that tomorrow, too tired now :D

Color the SeekArc (circular SeekBar) in the Sleep-timer dialog with the accent color

There is no method (or maybe just not public) available to change the color on runtime. But as it is possible via xml some reflection stuff should do the job here.

Tag editor FAB white accent color check not visible

FC at NavigationDrawerFragment.isDrawerOpen()

Toolbar, status bar, and nav bar views need to be included in the shared element transition so that partially scrolled grid items don't cause glitches over the toolbar when tapped

E.g. an item that's partially under the toolbar will jump over the toolbar when tapped before going to the new Activity.

Music sometimes stops playing when screen is off and the current track finishes

I cannot reproduce which makes it even harder for me to fix. I already use a wakelock in the service and I almost completely compared the wakelock related code with Apollo, CM Music Player (Eleven) and Jams Music Player. I just can't figure out what is wrong here.

Using the bus system to notify of theme changes is slow

I noticed quite a bit of lag after you change the general theme or colors, it appears to be because you're using the bus system.

Cabinet does it by storing whatever the previous value was when an Activity is first created. When the Activity resumes, it checks if those values changed, and recreates itself if they did.

Issue with tag editor visibility when keyboard is open

Android Auto and Chromecast support

I think Google's sample music player will help from Android Wear and Android Auto: https://github.com/googlesamples/android-UniversalMusicPlayer

Chromecast is a bit more difficult, if it isn't in that sample project already.

Seekbar tinting below Lollipop isnt working right

MDTintHelper.class

decompiled

seekBar.getProgressDrawable().setColorFilter(color, Mode.MULTIPLY);
            if(VERSION.SDK_INT >= 16) {
                seekBar.getThumb().setColorFilter(color, Mode.MULTIPLY);
            }

I think Mode.MULTIPLY is wrong here. Because it multiplies the stock blue color of seekBar with the color we want instead of overwriting the color.

If I set it too pink then the result is purple i.e.

Toolbar should slide up to show only tabs when scrolling down

Sorry about the spam of issues, lol. Just logging things so they're not forgotten.

Dynamic check box doesn't keep its color when unchecked and checked again

DrawableCompat from updated Google libraries now supports backwards compatible tint lists

MDTintHelper is no longer needed

Option to ignore media provider album art, but load album art directly from file / the folder

Add sliding up panel to replace MusicControlerActivity

In KitKat and below the fastscroller is not moving in drag

KitKat and below only (Lollipop works fine):

The fastscroller moves only when scrolling on the recyclerview itself. Ehen dragging although the fastscroller doesn't move it still scrolls the recyvlerview as it should.

Queue dialog should scroll to the current position when opened