GithubHelp home page GithubHelp logo

node-semver-stable's People

Contributors

kaelzhang avatar peterdavehello avatar

Stargazers

 avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

node-semver-stable's Issues

Should we treat all the versions not match the semver as non-stable?

Such as 1.1, 1.2.3-3, 1.2.3.4 will be non-stable, by the code I added here:
7062182

-  return !semver_obj.prerelease.length;
+  return semver_obj === null ? false : !semver_obj.prerelease.length;

Maybe we can return a int instead of boolean? 1 as stable, 0 as unstable, -1 as unstable.

What do you think @kaelzhang ? If you don't mind, I would like to send a PR to add this change ๐Ÿ‘

TypeError: Cannot read property 'prerelease' of null

Seems we'll get this error when the input cannot been parsed by semver ...

TypeError: Cannot read property 'prerelease' of null
at repl:1:12
at REPLServer.self.eval (repl.js:110:21)
at Interface. (repl.js:239:12)
at Interface.emit (events.js:95:17)
at Interface._onLine (readline.js:203:10)
at Interface._line (readline.js:532:8)
at Interface._ttyWrite (readline.js:761:14)
at ReadStream.onkeypress (readline.js๐Ÿ’ฏ10)
at ReadStream.emit (events.js:98:17)
at emitKey (readline.js:1096:12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.