kangasta / pileon Goto Github PK

Not a problem with small card size. Using em instead of px values units in box-shadow sizes might fix this also for other card sizes as well.

No moves to undo: default action (navigate to previous page or close application)
Moves to undo: undo to last move

Could try to, for example, make the row gap shorter and centering the cards.

Adjust styles so that hovering on buttons does not have effect on main content area size.

Cards are too big → adjust font size calculation.

For example 810 x 693 on Chrome application on desktop Mac.

• Fix svelte-check warnings. Run npm run eslint or npm run check to list these.
• Remove "svelte/valid-compile": "warn", override from eslint configuration.

For example:

const piles = [
  new Cards("J♠ 7♥ 7♦ 7♠"),
  new Cards("K♥ 7♣"),
];

See #99 for failing test that verifies this.

Split from #47

Check if there is best practise for double-click action. If not, use shift + enter/space.

For example: Cards 7♦ and Q♣ can be moved back and forth between two piles. There are noother possible moves. Undo the last move or start a new game.

• Extend infinite-loop detection logic to detect multiple infinite-loops.
• Update the message in Dead end modal.
• Include related cards in the Dead end modal message.

#95 Has a new unit-test that should pass after this has been fixed: example piles to re-produce:

const piles = [
  new Cards("J♠ Q♠ 7♥ 7♦"),
  new Cards("K♥ 4♣ 7♠"),
  new Cards("J♥ J♦ Q♦ Q♣"),
  new Cards("4♦ K♠ Q♥"),
];

Use auto instead of scroll for modal overflow value.

Short-cuts could be, for example:

Q W E R T
A S D F G
Z X C V B

This would only work in landscape mode, but that is likely more common with keyboard users. Implement so that the short-cuts are logical on non-QWERTY keyboards (e.g., German or French layouts). Keydown event from these keys should focus the target stack.

Similarly than on undo, any selection should be canceled when new game is started.