karolyp / docker-tar-pusher Goto Github PK

https://github.com/karolyp/docker-tar-pusher/blob/master/src/WorkDirUtils.ts#L10-L1

  public createTempDir(prefix = 'dtp-'): void {
    this.cwd = fs.mkdtempSync(path.join(os.tmpdir(), prefix));
  }

If two Docker tars are being uploaded at the same time, they use the same folder. To prevent this, generate pseudo-random folder names, e.g:

import { v4 as uuidv4 } from 'uuid'

  public createTempDir(prefix = 'dtp-'): void {
    this.cwd = fs.mkdtempSync(path.join(os.tmpdir(), prefix + uuidv4()));
  }

To comply with allowing minimum permissions, we'd like to be able to authenticate to our docker registry with a token that provides the access to just push to a single namespace. The registry lets you generate tokens with specific scopes as JWT tokens. It would be useful if this library allowed the user to provide an already generated JWT bearer token that it would use for authentication.

e.g.

const namespace = 'internal'
const image = 'nginx'

# user provided function for generating a token
const token = await generateAccessToken([{ type: 'repository', name: `${namespace}/${image}`, actions: ['push', 'pull'] }])

const options: DockerTarPusherOptions = {
  registryUrl: 'http://localhost:5000',
  ...
  auth: {
    token
  }
}

When accepting user generated tars, we want to force where the images are uploaded to.

Would be useful to have the ability to take in a logger, even if it's just a very simple:

logger: (msg: string) => void

This would let us integrate the module into our existing bunyan logger.