karranb / space-battleship Goto Github PK

Using a package like Zod, validate the messages send by the socket clients to the socket server, returning UNPROCESSED message when a message is invalid.

EG:

Create expected message parser and type

const SetUsernameMessage = z.object({
  name: z.string(),
  version: z.string(),
  countryCode: z.string().optional(),
});

type SetUsernameMessage = z.infer<typeof SetUsernameMessage>;

validate received unknown message

handleSetUserName(socket: Socket, message: unknown): void {
      ...
      const result = SetUsernameMessage.safeParse(message)
      if (result.success === false) {
        throw new SocketError('Invalid message')
      }
      const { name, version, countryCode } = result.data
      ...
}

• Room (node_server/src/core/game/mixins/room.ts)
• Challenge (node_server/src/core/game/mixins/challenge.ts)
• Game (node_server/src/core/game/mixins/game.ts)

make the game more attractive.

• Improve loading screen
• Fix some button images that are stretched
• Create a new quit button
• Create screen transitions
• Add sound effects when, for example, a user signs in / challenges you
• add some type of animations to the identification scene

add new translations to the game
https://github.com/karranb/space-battleship/tree/main/phaser_game/src/i18n

besides improving its content, one suggestion is to add some gameplay images

create a basic PR template, it can be based in any other repo

With git lab actions a simple job that runs checks the lint, run the tests, and tries to build the front and backend