kategray / dns-challenge-cloudflare Goto Github PK

The configuration section in README.md refers to /etc/dns-challenge.yaml, but the constant in Application.php looks for /etc/dns-challenge.yml

I ran into an issue where the command failed when the content of the record name starts with a - (dash).

I.e.

$ /usr/local/sbin/dns-challenge setup domain.tld -OT31337Nfb9oUNZTH4cKErfJXPsSVsIKJmrTewFsJ

                                   
  The "-O" option does not exist.  
                                   

setup <zone> <challenge>

My workaround here was to add -- (double dash) to specify end of command options for the MDChallengeDns01

MDChallengeDns01 /usr/local/sbin/dns-challenge --

The application can use a bit more documentation for consistency.

In SetupCommand.php, the TTL is still hard-coded:

        if (false !== $challenge) {
            // Create a new record
            $result = $dns->addRecord($zone_id, $record_type, $record, $challenge, 120, false);
        }

This needs to respect the configuration file.