kayabanerve / cryptonote-library Goto Github PK

The Curve25519 code used is modified Ed25519 reference code in pure, simple Python. This makes it infeasible for large operations, and it should be replaced with optimized Python/bound C.

These will not be handled by wallet2 and therefore are not usable as Monero transfers, making them critically flawed.

Beyond automating confirmation the selected mixins are recent enough, not always being the last mixin when doing frequent transactions would be beneficial. That said, there are some natural limitations to this (if you spend immediately after, you can only use mixins from the same block as your output; that alone would be suspicious).

When I wrote this, I had a lot of opinions on style. black was chosen out of simplicity, and while I disagree with it occasionally, I don't mind keeping it. That said, my excessive commenting does have to go, and I would like to move to a two-space ident.

https://web.getmonero.org/2018/09/25/a-post-mortum-of-the-burning-bug.html

A plan C wrapper combined with cdll to define the C interface in pure Python would be much cleaner.

Monero v12 used MLSAG transactions which have been disabled in favor of CLSAG. Because of that, this code won't work against the current Monero mainnet.