GithubHelp home page GithubHelp logo

Comments (6)

Vishalk91-4 avatar Vishalk91-4 commented on May 26, 2024 1

@He1pa, can I work on this issue

from kcl.

d4v1d03 avatar d4v1d03 commented on May 26, 2024 1

Hey @Peefy , i was understanding the code for the same and have made a PR regarding a test case for the same, please have a look. #1311 .
Though it doesn't solve this issue but i'll get it done by my next PR.

from kcl.

He1pa avatar He1pa commented on May 26, 2024 1

@Peefy I worked on hover.rs chnaged few things in build_schema and inside the hover function

But, can you exactly tell what the change needs to look like and if you have a little idea on where I mean I get the current one, like I'm seeing the same thing on hovering in the above example for the expected one

I don't understand what your problem is.
Our current hover is a text rendered in markdown format, like the first picture.
But we need to optimize it and add syntax highlighting to some keywords, like in the second picture (this is Rust's hover by rust-analyzer).
You need to investigate how to render colors in lsp hover. You can refer to other common language lsp practices. For example: https://github.com/rust-lang/rust-analyzer/blob/c0732c9f0f91bdc31d8da320be16d1db06c848d8/crates/rust-analyzer/src/handlers/request.rs#L1059

from kcl.

Vishalk91-4 avatar Vishalk91-4 commented on May 26, 2024

@Peefy I worked on hover.rs chnaged few things in build_schema and inside the hover function

But, can you exactly tell what the change needs to look like and if you have a little idea on where
I mean I get the current one, like I'm seeing the same thing on hovering in the above example for the expected one

from kcl.

Peefy avatar Peefy commented on May 26, 2024

cc @He1pa

from kcl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.