GithubHelp home page GithubHelp logo

charts's People

Contributors

aballman avatar adarsh-verma-14 avatar ahmelsayed avatar arschles avatar aslafy-z avatar blottn avatar chrisjohnson00 avatar emctl avatar eumel8 avatar jatinsanghvi avatar jeffhollan avatar jkremser avatar joebowbeer avatar jorturfer avatar khaosdoctor avatar mboutet avatar mkilchhofer avatar nissanitz avatar oded-dd avatar pragmaticivan avatar quentinbisson avatar satishranjan avatar t0rr3sp3dr0 avatar t3mi avatar tbickford avatar tomasspi avatar tomkerkhove avatar v-shenoy avatar zerodayyy avatar zroubalik avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

charts's Issues

Creating official releases

I presume we'll be using GitHub releases for official releases rather than just updating the repo or?

Restructure values to feel more natural

Restructure values to feel more natural based on @ncrothe his original proposal in #27:

On a more general note: Looking at the structure of the values section, the multi-component nature of the chart and other charts I have seen, I do, however, think you might want to consider switching from a . structure to . eventually.

I.e. from

annotations:
  operator:
  apiserver:

etc. to something like

operator:
  image:
  replicaCount:
  podAnnotations:
metrics:
  image:
  replicaCount:
  podAnnotations:

Though this does go well beyond the scope of an MR like this and would also break existing deployments. But something to consider for a future version bump.

Update Commands and output in README.md

1) The added repo is keda but the document is showing kedacore in the helm search

2) The README shows the commands as:

$ helm search repo keda/

NAME            CHART VERSION   APP VERSION     DESCRIPTION
kedacore/keda   1.5.0           1.5.0           Event-based autoscaler for workloads on Kubernetes

However when we do the helm search we find this :

$ helm search repo keda/

NAME     	CHART VERSION	APP VERSION	DESCRIPTION                                       
keda/keda	2.0.1        	2.0.0      	Event-based autoscaler for workloads on Kubernetes

Incorrect apiGroup in keda-clusterrole

Yesterday I deployed keda using helm chart with version 2.0.0-beta.1.1. Now my keda operator and keda metrics apiserver log errors:

Failed to list *v1alpha1.ScaledObject: scaledobjects.keda.sh is forbidden: User "system:serviceaccount:keda:keda-operator" cannot list resource "scaledobjects" in API group "keda.sh" at the cluster scope
scaledobjects.keda.sh is forbidden: User \"system:serviceaccount:keda:keda-operator\" cannot list resource \"scaledobjects\" in API group \"keda.sh\" at the cluster scope

I think the problem is here (https://github.com/kedacore/charts/blob/master/keda/templates/10-keda-clusterrole.yaml#L50):

- apiGroups:
  - keda.k8s.io
  resources:
  - '*'
  verbs:
  - '*'

Cannot create resource "customresourcedefinitioins"

During installing KEDA by using helm install keda kedacore/keda I've got following error:

Error: failed to install CRD crds/keda.k8s.io_scaledobjects_crd.yaml: customresourcedefinitions.apiextensions.k8s.io is forbidden: User "u-f6efqrxwsu" cannot create resource "customresourcedefinitions" in API group "apiextensions.k8s.io" at the cluster scope

CRDs are failing to install on K8s v1.15.11

Hello,

Looks like #94 breaks compatibility with Kubernetes versions prior to 1.16. I was trying to install the chart but I'm getting

Error: failed to install CRD crds/scaledjobs.keda.sh.yaml: unable to recognize "": no matches for kind "CustomResourceDefinition" in version "apiextensions.k8s.io/v1"

I'm running EKS v1.15.11.
Was this breaking change expected?

Unable to Install KEDA - Conflicts with Datadog Helm chart

We run the datadog agents on our cluster, and as part of that it runs the metric server. We are unable to install KEDA, because it appears to conflict.

STDERR:
  Error: Failed to render chart: exit status 1: Error: rendered manifests contain a resource that already exists. Unable to continue with install: APIService "v1beta1.external.metrics.k8s.io" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; annotation validation error: key "meta.helm.sh/release-name" must equal "keda": current value is "datadog"
  Error: plugin "diff" exited with error

Is there anyway to use the existing metrics server?

Thanks,

Getting error on helm update

G'day everyone!

This is the first time ever that I'm deploying Keda manifests using a helm chart.
I'm trying to deploy my application to my AKS cluster. At the time Helm is doing the Upgrade I get this error:

Error: UPGRADE FAILED: rendered manifests contain a resource that already exists. Unable to continue with update: ScaledObject "My-Chart-Name" in namespace "My-Namespace" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "My-Chart-Name"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "My-Namespace"
Do I really need this labels? Because I don't use it in my deployment for example and It worked just fine, this problem just happen when I create a manifest for Keda.

My folder tree is like:

Chart-Folder
└── templates
    └── deployment.yml
    └── scaledobject.yml
└── Chart.yaml
└── values.yml

My scaledobject.yml is like:

apiVersion: keda.k8s.io/v1alpha1
kind: ScaledObject
metadata:
  name: {{ .Chart.Name }}
  labels:
    app: {{ .Chart.Name }}
    deploymentName: {{ .Chart.Name }}
spec:
  scaleTargetRef:
    deploymentName: {{ .Chart.Name }}
  minReplicaCount: 0
  maxReplicaCount: 10
  pollingInterval: 1
  triggers:
  - type: azure-servicebus
    metadata:
      topicName: My-Topic
      subscriptionName: My-Subscription
      messageCount: '1'
      connection: AzureWebJobsStorage

My chart.yml:

apiVersion: v1
appVersion: "1.0"
description: My Description
name: My Chart name
version: 0.1.0

Does anyone has a clue of what I'm missing here?

Thanks!

Solve issue with deploying Keda using "securityContext.readOnlyRootFilesystem: true"

keda-operator-metrics-apiserver refuses to start when I install Keda using Helm 3 with the following values.yaml file:

securityContext:
  capabilities:
    drop:
    - ALL
  readOnlyRootFilesystem: true # The setting that creates issues
  runAsNonRoot: true
  runAsUser: 1000

Earlier we have "solved" the problem by:

  • using "helm template" to create a helm template
  • use kustomize to patch the keda-operator-metrics-apiserver deployment so that two emptydir volumes are mounted as /tmp and /apiserver.local.config
  • apply the patched yaml files

But we plan on making some changes to our deployment process so that this extra step makes the deployment process more cumbersome.

It would be good to be able to solve this issue using some kind of Helm variable (possibly using Helm variables with a name similar to additionalVolumes & additionalVolumeMounts).

It's not extremely important that these pods have a read only file system, but we plan on adding policies enforcing the use of read-only pod root file systems, and it would be good not to have to create an exception for the Keda deployment/avoid the extra complexity of patching these Helm generated yaml files.

Use Namespaced CRD scope

Hi,

I have a use-case with an OpenShift cluster with high CRD restrictions. We are forced, in order to use CRD, to deploy them with a Namespaced scope.

This allows a CRD to only operate inside a namespace. Useful for security & segregation purposes.

Could it be possible to allow the customization of these in the chart?

Example:

apiVersion: apiextensions.k8s.io/v1beta1 
kind: CustomResourceDefinition
metadata:
  name: crontabs.stable.example.com 
spec:
  group: stable.example.com 
  version: v1 
  scope: Namespaced 
  names:
    plural: crontabs 
    singular: crontab 
    kind: CronTab 
    shortNames:
    - ct

Doc & Sources:

.tgz file contains backslashes when using keda chart as a subchart on macOS (and probably linux in general)

.tgz file contains backslashes when using keda chart as a subchart on macOS (and probably linux in general).

  1. To reproduce, create a chart with the following Chart.yaml:
apiVersion: v2
appVersion:  0.0.0
description: test
name: test
version: 0.0.0

dependencies:
  - name: keda
    repository: https://kedacore.github.io/charts
    version: =1.3.2
  1. run helm dependency update test. This will create the the test/charts/keda-1.3.2.tgz file.
  2. Then, untar the file using tar xf test/charts/keda-1.3.2.tgz -v
  3. The extracted files are not in the expected folder structure.

Output of helm version:
version.BuildInfo{Version:"v3.1.2", GitCommit:"d878d4d45863e42fd5cff6743294a11d28a9abce", GitTreeState:"clean", GoVersion:"go1.13.8"}

Error with helm install on 2.0.0-rc2

A clear and concise description of what the bug is.

Expected Behavior

Successful install of Keda

Actual Behavior

Receive the following error when installing with Helm

Error: FAILED: rendered manifests contain a resource that already exists. Unable to continue with update: CustomResourceDefinition "triggerauthentications.keda.sh" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "keda"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "keda"

Steps to Reproduce the Problem

  1. kubectl create ns keda
  2. helm install keda kedacore/keda --version 2.0.0-rc2 --namespace keda

Specifications

  • KEDA Version: 2.0.0-rc2
  • Platform & Version: Helm v3
  • Kubernetes Version: 1.19.0
  • Scaler(s): NA

Re-introduce README for Helm chart

We used to have a README in our Helm chart which documented what it was, how you can deploy it and what configuration options we provide.

This seems to have been removed during our move to this repo and should be re-introduced to improve the ease of use.

KEDA v2 Support

It would be great to have the KEDA v2 Helm Chart as a separate branch. Is there any plan on supporting KEDA v2 in this charts repository?

Publish Helm chart to an OCI-compatible repo to support versioning

When we moved to this repo, we decided to move away from hosting our charts on https://kedacore.azureedge.net/helm over https://kedacore.github.io/charts. (see helm/hub#181)

Unfortunately, this means that we are losing our Helm chart versioning.

I'd suggest to publish our Helm chart to an OCI-compatible repo such as Azure Container Registry so that:

  1. We can version our Helm charts
  2. We can use releases on this repo to track changes
  3. People who are using an older version can stick to an older chart

Error no matches for kind ScaledObject in version keda.sh/v1alpha1

I am trying to install KEDA through ArgoCD. Am getting the below error.

ERROR   controller-runtime.source       if kind is a CRD, it should be installed before calling
Start   {"kind": "ScaledJob.keda.sh", "error": "no matches for kind \"ScaledJob\" in version \"keda.sh/v1alpha1\""}
github.com/go-logr/zapr.(*zapLogger).Error
        /go/pkg/mod/github.com/go-logr/[email protected]/zapr.go:128
sigs.k8s.io/controller-runtime/pkg/source.(*Kind).Start
        /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/source/source.go:117
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1
        /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:140
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start
        /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:175
sigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).startRunnable.func1
        /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/manager/internal.go:661
2020-11-11T12:56:52.245Z        ERROR   controller-runtime.source       if kind is a CRD, it should be installed before calling
Start   {"kind": "ScaledObject.keda.sh", "error": "no matches for kind \"ScaledObject\" in version \"keda.sh/v1alpha1\""}
github.com/go-logr/zapr.(*zapLogger).Error
        /go/pkg/mod/github.com/go-logr/[email protected]/zapr.go:128
sigs.k8s.io/controller-runtime/pkg/source.(*Kind).Start
        /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/source/source.go:117
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1
        /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:140
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start
        /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:175
sigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).startRunnable.func1
        /go/pkg/mod/sigs.k8s.io/[email protected]/pkg/manager/internal.go:661
2020-11-11T12:56:52.245Z        ERROR   setup   problem running manager {"error": "no matches for kind \"ScaledJob\" in version
\"keda.sh/v1alpha1\""}
github.com/go-logr/zapr.(*zapLogger).Error
        /go/pkg/mod/github.com/go-logr/[email protected]/zapr.go:128
main.main
        /workspace/main.go:119
runtime.main
        /usr/local/go/src/runtime/proc.go:204

Specifications

KEDA Version: 2.0
Kubernetes Version: 1.18

Screenshot from 2020-11-11 09-47-47

keda-operator error after deployment

I installed keda-operator on Kubernetes 1.15 using Helm 2 helm install kedacore/keda command.
In the log file there is the following error:
{"level":"info","ts":1589781448.036523,"logger":"cmd","msg":"KEDA Version: 1.4.1"}
{"level":"info","ts":1589781448.0365922,"logger":"cmd","msg":"Go Version: go1.13.3"}
{"level":"info","ts":1589781448.0366158,"logger":"cmd","msg":"Go OS/Arch: linux/amd64"}
{"level":"info","ts":1589781448.0366275,"logger":"cmd","msg":"Version of operator-sdk: v0.11.0"}
{"level":"info","ts":1589781448.03694,"logger":"leader","msg":"Trying to become the leader."}
{"level":"info","ts":1589781448.357414,"logger":"leader","msg":"Found existing lock with my name. I was likely restarted."}
{"level":"info","ts":1589781448.357453,"logger":"leader","msg":"Continuing as the leader."}
{"level":"info","ts":1589781448.661053,"logger":"controller-runtime.metrics","msg":"metrics server is starting to listen","addr":"0.0.0.0:8383"}
{"level":"info","ts":1589781448.6612098,"logger":"cmd","msg":"Registering Components."}
{"level":"info","ts":1589781448.6614869,"logger":"controller-runtime.controller","msg":"Starting EventSource","controller":"scaledobject-controller","source":"kind source: /, Kind="}
{"level":"error","ts":1589781450.4600754,"logger":"controller-runtime.source","msg":"if kind is a CRD, it should be installed before calling Start","kind":"ScaledObject.keda.k8s.io","error":"no matches for kind "ScaledObject" in version "keda.k8s.io/v1alpha1"","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\t/go/pkg/mod/github.com/go-logr/[email protected]/zapr.go:128\nsigs.k8s.io/controller-runtime/pkg/source.(*Kind).Start\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/source/source.go:88\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Watch\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:122\ngithub.com/kedacore/keda/pkg/controller/scaledobject.add\n\tkeda/pkg/controller/scaledobject/scaledobject_controller.go:59\ngithub.com/kedacore/keda/pkg/controller/scaledobject.Add\n\tkeda/pkg/controller/scaledobject/scaledobject_controller.go:42\ngithub.com/kedacore/keda/pkg/controller.AddToManager\n\tkeda/pkg/controller/controller.go:13\nmain.main\n\tkeda/cmd/manager/main.go:114\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:203"}
{"level":"error","ts":1589781450.4601953,"logger":"cmd","msg":"","error":"no matches for kind "ScaledObject" in version "keda.k8s.io/v1alpha1"","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\t/go/pkg/mod/github.com/go-logr/[email protected]/zapr.go:128\nmain.main\n\tkeda/cmd/manager/main.go:115\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:203"}

Allow external metrics requests to be done with different multiple identities

What we are trying to achieve:

We have different namespaces (teams), accessing external (azure resources) metrics.
We would like those teams each to use it's own Azure AAD Identity - to ensure least privilege access.
At the best scenario, we would even like to access each resource with separate Identity ,(AAD Pod Identity project).

We are fine with both installing single shared Keda metrics server, Wich will pick the identities from CRD per resource or something like that, or having KEDA metrics server installed per namespace.

We just looking the external requests for the metrics to be done at least by per-namespace identities.

If you think it is impossible with current Keda architecture - can you explain which workaround can be taken, and to provide some draft of estimation for this effort - we'd consider the contribution here.

Chart expects Helm 3 / apiVersion: v2, but is published as 2/v1

Hello:

At https://kedacore.github.io/charts/index.yaml, the chart version 2.0.0 is published as apiVersion: v1:

keda:
  - apiVersion: v1
    appVersion: 2.0.0
    created: "2020-11-04T15:14:39.6686554+01:00"
    description: Event-based autoscaler for workloads on Kubernetes
    digest: dba8b0e793085165c7d155f9393c5ff112d4714dbce0201404ceb0e67d1b2deb
    home: https://github.com/kedacore/keda
    icon: https://raw.githubusercontent.com/kedacore/keda/master/images/keda-logo-500x500-white.png
    maintainers:
    - email: [email protected]
      name: Ahmed ElSayed
    - email: [email protected]
      name: Tom Kerkhove
    - email: [email protected]
      name: Zbynek Roubalik
    name: keda
    sources:
    - https://github.com/kedacore/keda
    urls:
    - https://kedacore.github.io/charts/keda-2.0.0.tgz
    version: 2.0.0

Could the chart be incremented and republished as apiVersion: v2? Thank you!

Move the CRDs from `crds/` to `templates/` to maintain them

As per: https://helm.sh/docs/chart_best_practices/custom_resource_definitions/#install-a-crd-declaration-before-using-the-resource

There is no support at this time for upgrading or deleting CRDs using Helm. This was an explicit decision after much community discussion due to the danger for unintentional data loss. Furthermore, there is currently no community consensus around how to handle CRDs and their lifecycle. As this evolves, Helm will add support for those use cases.

This means that after the first install, changes to our existing CRDs or the introduction of new ones will not be reflected in end-users their clusters which is a fundamental problem.

We will move the CRDs from crds/ to templates/ with an option to opt-in to install the CRDs.

This is also similar to how cert-manager Helm chart handles things:
https://artifacthub.io/packages/helm/jetstack/cert-manager?modal=template&template=crds.yaml

Solves #139

Helm upgrade fails to install clustertriggerauthentications crd

Report

Hi,
Not sure if this is the correct place for this however, here we go...
Helm upgrade from 2.0.0 to 2.2.0 fails to install (clustertriggerauthentications.keda.sh crd)
We're running keda v2.0.0 installed via helm 3 on v1.19.6 (AKS)

  • Installed using --set=installCRDs=true --set=podIdentity.activeDirectory.identity=<aad_identity>

Since the crd is missing pod fails to start.
(no matches for kind "ClusterTriggerAuthentication" in version "keda.sh/v1alpha1)

Expected Behavior

Missing components are installed and images are upgraded to the version specified.

Actual Behavior

Images get upgraded to the version specified.
Missing components are not installed, in this case clustertriggerauthentications.keda.sh is not installed.

If I manually install the missing crd, everything works as expected.

Steps to Reproduce the Problem

  1. Ensure that keda crds are not already installed
  2. helm install keda kedacore/keda -n keda --version=2.0.0 --set=installCRDs=true --set=podIdentity.activeDirectory.identity=<aad_identity> --debug
  3. helm upgrade helm install keda kedacore/keda -n keda --version=2.2.0 --debug
  4. check pod logs, check crd

Logs from KEDA operator

2021-03-26T14:47:51.962Z	INFO	controller-runtime.metrics	metrics server is starting to listen	{"addr": ":8080"}
2021-03-26T14:47:51.965Z	INFO	controllers.ScaledObject	Running on Kubernetes 1.19	{"version": "v1.19.6"}
2021-03-26T14:47:51.965Z	INFO	setup	Starting manager
2021-03-26T14:47:51.965Z	INFO	setup	KEDA Version: 2.2.0
2021-03-26T14:47:51.965Z	INFO	setup	Git Commit: 6dc4c3524ba6278276cd1338cc7e4e9a7dd88963
2021-03-26T14:47:51.965Z	INFO	setup	Go Version: go1.15.6
2021-03-26T14:47:51.965Z	INFO	setup	Go OS/Arch: linux/amd64
I0326 14:47:51.966071       1 leaderelection.go:243] attempting to acquire leader lease keda/operator.keda.sh...
2021-03-26T14:47:51.966Z	INFO	controller-runtime.manager	starting metrics server	{"path": "/metrics"}
I0326 14:48:09.381707       1 leaderelection.go:253] successfully acquired lease keda/operator.keda.sh
2021-03-26T14:48:09.381Z	INFO	controller	Starting EventSource	{"reconcilerGroup": "keda.sh", "reconcilerKind": "ScaledJob", "controller": "scaledjob", "source": "kind source: /, Kind="}
2021-03-26T14:48:09.381Z	INFO	controller	Starting EventSource	{"reconcilerGroup": "keda.sh", "reconcilerKind": "ClusterTriggerAuthentication", "controller": "clustertriggerauthentication", "source": "kind source: /, Kind="}
2021-03-26T14:48:09.381Z	INFO	controller	Starting EventSource	{"reconcilerGroup": "keda.sh", "reconcilerKind": "TriggerAuthentication", "controller": "triggerauthentication", "source": "kind source: /, Kind="}
2021-03-26T14:48:09.381Z	INFO	controller	Starting EventSource	{"reconcilerGroup": "keda.sh", "reconcilerKind": "ScaledObject", "controller": "scaledobject", "source": "kind source: /, Kind="}
2021-03-26T14:48:09.482Z	INFO	controller	Starting Controller	{"reconcilerGroup": "keda.sh", "reconcilerKind": "ScaledJob", "controller": "scaledjob"}
2021-03-26T14:48:10.285Z	ERROR	controller-runtime.source	if kind is a CRD, it should be installed before calling Start	{"kind": "ClusterTriggerAuthentication.keda.sh", "error": "no matches for kind \"ClusterTriggerAuthentication\" in version \"keda.sh/v1alpha1\""}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:143
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:184
sigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).startRunnable.func1
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/manager/internal.go:676
2021-03-26T14:48:10.285Z	INFO	controller	Starting workers	{"reconcilerGroup": "keda.sh", "reconcilerKind": "ScaledJob", "controller": "scaledjob", "worker count": 1}
2021-03-26T14:48:10.285Z	INFO	controller	Stopping workers	{"reconcilerGroup": "keda.sh", "reconcilerKind": "ScaledJob", "controller": "scaledjob"}

KEDA Version

2.2.0

Kubernetes Version

1.19

Platform

Microsoft Azure

Scaler Details

Azure Service Bus

Allow pod annotations via Chart

We would like to automatically add annotations to the controller and metrics pod. This currently does not seem possible via the helm chart. Please add this capability.

Our specific use case would be for kiam instance role annotations for AWS auth.

Automate release process

Automate release process based on a new GitHub release that is created (#4) similar to how KEDA core works.

Helm chart v2.0.0-rc2 fails to install on fresh k8s 1.18.8

Attempting to install the chart fails with error

duah-infrastructure git:(master) ✗ helm install keda kedacore/keda --version 2.0.0-rc2 --namespace keda       
Error: rendered manifests contain a resource that already exists. Unable to continue with install: CustomResourceDefinition "scaledjobs.keda.sh" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "keda"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "keda"

screenshot

Expected Behavior

It is able to install on a fresh cluster

Actual Behavior

It does not install

Steps to Reproduce the Problem

  1. Attempt to install

Specifications

  • KEDA Version: 2.0.0-rc2
  • Platform & Version: Azure, AKS, fresh as of 26/10/2020
  • Kubernetes Version: 1.18.8

Version should be updated to 1.4.0 not to 1.3.2

@SatishRanjan when you did release, you haven't updated version to 1.4.0. The PR should be checked and be approved by at least one person to avoid these kind of problems.

charts/keda/Chart.yaml

Lines 7 to 11 in 345ae43

version: 1.3.2
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application.
appVersion: 1.4.0

Allow the http-add-on chart to use the 'latest' tag

Currently the HTTP add on chart defaults to a vX.Y.Z tag. We should allow users to install the latest tag as well. This

Use-Case

Users who would like to stay on the latest stable release may want to just use latest (along with an ImagePullPolicy of Always) to stay up to date.

Specification

cc/ @khaosdoctor

Missing CRD labels/annotations cause helm upgrade failure

When upgrading from keda chart version 2.1.2 => 2.2.2 I receive the following errors that crd labels and annotations are missing. The CRDs that are affected are:

  • clustertriggerauthentications.keda.sh
  • scaledjobs.keda.sh
  • scaledobjects.keda.sh
  • triggerauthentications.keda.sh

Adding the following labels and annotations fixes the issue:

labels:
  app.kubernetes.io/managed-by: Helm
annotations:
  meta.helm.sh/release-name: keda
  meta.helm.sh/release-namespace: keda

Expected Behavior

The helm upgrade command successfully upgrades the chart.

Actual Behavior

The helm upgrade fails with these errors:

Error: UPGRADE FAILED: rendered manifests contain a resource that already exists. Unable to continue with update: CustomResourceDefinition "clustertriggerauthentications.keda.sh" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "keda"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "keda"

Error: UPGRADE FAILED: rendered manifests contain a resource that already exists. Unable to continue with update: CustomResourceDefinition "clustertriggerauthentications.keda.sh" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "keda"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "keda"

Error: UPGRADE FAILED: rendered manifests contain a resource that already exists. Unable to continue with update: CustomResourceDefinition "scaledjobs.keda.sh" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "keda"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "keda"

Error: UPGRADE FAILED: rendered manifests contain a resource that already exists. Unable to continue with update: CustomResourceDefinition "scaledobjects.keda.sh" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "keda"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "keda"

Error: UPGRADE FAILED: rendered manifests contain a resource that already exists. Unable to continue with update: CustomResourceDefinition "triggerauthentications.keda.sh" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "keda"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "keda"

Steps to Reproduce the Problem

  1. Install keda chart version 2.1.2.
  2. Upgrade keda chart version to 2.2.2. The upgrade fails with the errors above.

Specifications

  • KEDA Version: 2.1.2
❯ helm version
version.BuildInfo{Version:"v3.5.2", GitCommit:"167aac70832d3a384f65f9745335e9fb40169dc2", GitTreeState:"dirty", GoVersion:"go1.15.7"}

❯ kubectl version
Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.3", GitCommit:"1e11e4a2108024935ecfcb2912226cedeafd99df", GitTreeState:"clean", BuildDate:"2020-10-14T12:50:19Z", GoVersion:"go1.15.2", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"18+", GitVersion:"v1.18.17-gke.100", GitCommit:"c702fe983d18291df698149425102b51a8258b71", GitTreeState:"clean", BuildDate:"2021-03-19T09:19:23Z", GoVersion:"go1.13.15b4", Compiler:"gc", Platform:"linux/amd64"}

Run KEDA with readOnlyRootFilesystem

Hi,

I am running KEDA v2.0.0 and trying to set readOnlyRootFilesystem: true due to security concerns, but I am getting the following error from keda-operator-metrics-apiserver:

E1117 09:29:17.080262       1 main.go:116] keda_metrics_adapter "msg"="unable to run external metrics adapter" "error"="error creating self-signed certificates: open apiserver.local.config/certificates/apiserver.crt: read-only file system" 

Is there a way to enable read only fs for KEDA?

Thanks.

Helm 3 install failed

When I am trying to install Keda in minikube via Helm3, it throws below error.

helm install keda kedacore/keda --namespace keda                                                                                  
manifest_sorter.go:175: info: skipping unknown hook: "crd-install"
manifest_sorter.go:175: info: skipping unknown hook: "crd-install"
NAME: keda
LAST DEPLOYED: Sun Nov 24 18:22:12 2019
NAMESPACE: keda
STATUS: deployed
REVISION: 1
TEST SUITE: None

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.