GithubHelp home page GithubHelp logo

Comments (14)

keeferrourke avatar keeferrourke commented on September 6, 2024 2

@tim77 FYI, I just cut a new release (first time in >2 years 😳)

from la-capitaine-icon-theme.

shuriken1812 avatar shuriken1812 commented on September 6, 2024 1

@keeferrourke I personally think rpm has its own logo as artem pointed out on the bugzilla.

Example of such icons -

Screenshot from 2021-04-23 22-54-37
Screenshot from 2021-04-23 22-57-55

It refers to RPM meters in cars. It will eliminate the need of different fedora red hat configuration. Also it will be a standard rpm icon in the style of la-capitaine mimetypes. I don't think there is any other configuration differences between the two distros for the icon theme.

from la-capitaine-icon-theme.

shuriken1812 avatar shuriken1812 commented on September 6, 2024 1

Its settled and i don't think any changes are necessary.
Everything that can be done in mock can be done without mock. Mock runs rpmbuild in an isolated environment consisting of a minimal set of packages. Those package don't include what it requires to see the distribution logo. If artem run rpmbuild on his own system it will build the package without any issue. Its nothing wrong about the config script. See Mock as just a fedora container with very minimal packages or chroot which may not satisfy everything 👍

from la-capitaine-icon-theme.

tim77 avatar tim77 commented on September 6, 2024 1

@tim77 FYI, I just cut a new release (first time in >2 years flushed)

Great! 👍 I would like if we switch to releases instead of git snapshots TBH. Not a big issue, but this more practical.

from la-capitaine-icon-theme.

keeferrourke avatar keeferrourke commented on September 6, 2024

Hey @jatin-cbs I read through the linked bugzilla issue, but I'm not sure what Mock is, or how you would want me to make the configuration script "more friendly" to that tool. Can you please advise?

(Sorry for the delayed reply, I'm just finishing up exams for my final semester of school.)

from la-capitaine-icon-theme.

tim77 avatar tim77 commented on September 6, 2024

Mock it is a systemd-nspawn container for building software on Fedora/RHEL/CentOS.

from la-capitaine-icon-theme.

keeferrourke avatar keeferrourke commented on September 6, 2024

Ok so @jatin-cbs what exactly is the issue here?

Is it that you want me to change the configuration script (if so, in what way?), or is it that my mimetypes should be using a different (default but configurable? non-configurable?) icon for RPMs?

from la-capitaine-icon-theme.

keeferrourke avatar keeferrourke commented on September 6, 2024

Follow-up question: Where are these example mimetype icons from? Are they displaying an official logo, or is this artistic license?

At least according to Wikipedia / rpm.org, this appears to be the official logo for the package manager.

from la-capitaine-icon-theme.

shuriken1812 avatar shuriken1812 commented on September 6, 2024

The issue that there is different configuration for fedora and redhat, and configuration script won't be able to run in mock as stated. I can ask artem for configuration file changes. However we think that its more practical to simply change the .rpm mimetype logo to something more standard rather than fedora / redhat logos/ suse.

These icons are from Qogir and white sur theme respectively. they are artistic not official logo but inspired from the standard official rpm logo that is on the wikipedia which resembles an rpm meter.

from la-capitaine-icon-theme.

keeferrourke avatar keeferrourke commented on September 6, 2024

Okay thanks. I'm hesitant to remove the customization options for these mimetypes, but I'd be happy to add a different default RPM mimetype icon that closely resembles the official RPM logo, then still allow for the configuration script to overwrite this with distro-specific icons.

@jatin-cbs I'll link this issue in a PR later today, and tag you for review to make sure it's an ok solution for the bugzilla bug.

from la-capitaine-icon-theme.

shuriken1812 avatar shuriken1812 commented on September 6, 2024

@keeferrourke Distro logos are creative way and some people do like it. So Yes I agree.

We can change default rpm icons to a new standard one and still keep distro specific rpm configuration.

rpm.svg , application-x-rpm.svg , gnome-mime-application-x-rpm.svg , application-x-source-rpm.svg

Currently these are directly / indirectly linked to application-x-rpm-redhat.svg by default.

from la-capitaine-icon-theme.

keeferrourke avatar keeferrourke commented on September 6, 2024

#605 Should address the immediate issue of RedHat branding showing up in Fedora. I'm still unsure why the configure script isn't compatible with the Mock tool though, and how this causes possible packaging issues.

I'd like to make this easy to package, so @jatin-cbs @tim77 let's talk about possible changes to the configuration script in a new issue. Feel free to open a new bug at your leisure.

All the best!

from la-capitaine-icon-theme.

tim77 avatar tim77 commented on September 6, 2024

I hope i fixed or at least improved current build in Fedora but need to test (f34 only for now). At least distro vendor should configured correctly.

This is partial fix for RH#1950614 since we wait for #605 merged.

from la-capitaine-icon-theme.

keeferrourke avatar keeferrourke commented on September 6, 2024

Alright #605 is merged to master! Thanks all!

from la-capitaine-icon-theme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.