Comments (1)
The need for having PullRequest
be the main entity which stores info related to that PR is more pressing now with commit line comments. This is because the original hit to /commits
contains comment_count
info which we then want to at a later point fetch. We currently have to do it RIGHT NOW else we lose the count information because we ain't got nowhere to store it.
from github-pull-review.
Related Issues (20)
- Comment line is wrong when viewing non BASE-HEAD diffs HOT 1
- `/list` should show mentioned/involved_with
- Clicking on a line number should draw focus to the new comment box
- Annotate references to PRs with their status
- Action todo state should actually be tri-state HOT 1
- `pre` blocks overflow
- Sort out list / auth pages HOT 1
- Report travis/similar results on Merge page
- File moves look weird in diffs page HOT 1
- PR with only comments from the author should be "Awaiting review" not "Reviewed"
- Put PR number and repo in title
- Show commit comments HOT 2
- Diff parser breaks for submodule updates
- Merge pull request commit message repeats itself
- Add LGTM button to pull requests
- Toggle button to make all diffs in a PR be unified rather than split.
- Overview page incorrectly says "awaiting your response"
- Show a ruler in diffs
- Comments on moved files fail with 422 Unprocessable Entity
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-pull-review.