Comments (2)
e.g.
curl https://api.github.com/repos/illicitonion/testrepo/commits/e8da5c82f69503727ab683f503aeb1fbd7279f78
{
"sha": "e8da5c82f69503727ab683f503aeb1fbd7279f78",
"commit": {
"comment_count": 1
},
"comments_url": "https://api.github.com/repos/illicitonion/testrepo/commits/e8da5c82f69503727ab683f503aeb1fbd7279f78/comments"
}
curl https://api.github.com/repos/illicitonion/testrepo/commits/e8da5c82f69503727ab683f503aeb1fbd7279f78/comments
[
{
"url": "https://api.github.com/repos/illicitonion/testrepo/comments/14843072",
"html_url": "https://github.com/illicitonion/testrepo/commit/e8da5c82f69503727ab683f503aeb1fbd7279f78#commitcomment-14843072",
"id": 14843072,
"user": {
"login": "illicitonion",
"id": 1131704,
"avatar_url": "https://avatars.githubusercontent.com/u/1131704?v=3",
"gravatar_id": "",
"url": "https://api.github.com/users/illicitonion",
"html_url": "https://github.com/illicitonion",
"followers_url": "https://api.github.com/users/illicitonion/followers",
"following_url": "https://api.github.com/users/illicitonion/following{/other_user}",
"gists_url": "https://api.github.com/users/illicitonion/gists{/gist_id}",
"starred_url": "https://api.github.com/users/illicitonion/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/illicitonion/subscriptions",
"organizations_url": "https://api.github.com/users/illicitonion/orgs",
"repos_url": "https://api.github.com/users/illicitonion/repos",
"events_url": "https://api.github.com/users/illicitonion/events{/privacy}",
"received_events_url": "https://api.github.com/users/illicitonion/received_events",
"type": "User",
"site_admin": false
},
"position": 5,
"line": 5,
"path": "README.md",
"commit_id": "e8da5c82f69503727ab683f503aeb1fbd7279f78",
"created_at": "2015-12-08T10:05:07Z",
"updated_at": "2015-12-08T10:05:07Z",
"body": "NINE IS TOTALLY WRONG"
}
]
from github-pull-review.
These comments do not have any Patch
information which means I can't make a LineComment
correctly annoyingly... they should be able to be made without this information. A better data model would be:
PullRequest {
commits: Commit[]
comments: Comment[]
}
Commit {
patch: Patch;
lineComments: LineComment[];
}
Whereas atm we have:
PullRequest {
lineComments: LineComment[];
commits: Commit[];
}
Commit {}
LineComment {
patch: Patch;
}
This needs to be sorted out before we can do this. On the plus side, the glue is in place now request-wise, so it should be a quick fix once this is done.
from github-pull-review.
Related Issues (20)
- Comment line is wrong when viewing non BASE-HEAD diffs HOT 1
- `/list` should show mentioned/involved_with
- Clicking on a line number should draw focus to the new comment box
- Annotate references to PRs with their status
- Action todo state should actually be tri-state HOT 1
- `pre` blocks overflow
- Store system HOT 1
- Sort out list / auth pages HOT 1
- Report travis/similar results on Merge page
- File moves look weird in diffs page HOT 1
- PR with only comments from the author should be "Awaiting review" not "Reviewed"
- Put PR number and repo in title
- Diff parser breaks for submodule updates
- Merge pull request commit message repeats itself
- Add LGTM button to pull requests
- Toggle button to make all diffs in a PR be unified rather than split.
- Overview page incorrectly says "awaiting your response"
- Show a ruler in diffs
- Comments on moved files fail with 422 Unprocessable Entity
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from github-pull-review.