GithubHelp home page GithubHelp logo

Show commit comments about github-pull-review HOT 2 OPEN

kegsay avatar kegsay commented on June 12, 2024
Show commit comments

from github-pull-review.

Comments (2)

illicitonion avatar illicitonion commented on June 12, 2024

e.g.

curl https://api.github.com/repos/illicitonion/testrepo/commits/e8da5c82f69503727ab683f503aeb1fbd7279f78
{
  "sha": "e8da5c82f69503727ab683f503aeb1fbd7279f78",
  "commit": {
    "comment_count": 1
  },
  "comments_url": "https://api.github.com/repos/illicitonion/testrepo/commits/e8da5c82f69503727ab683f503aeb1fbd7279f78/comments"
}


curl https://api.github.com/repos/illicitonion/testrepo/commits/e8da5c82f69503727ab683f503aeb1fbd7279f78/comments
[
  {
    "url": "https://api.github.com/repos/illicitonion/testrepo/comments/14843072",
    "html_url": "https://github.com/illicitonion/testrepo/commit/e8da5c82f69503727ab683f503aeb1fbd7279f78#commitcomment-14843072",
    "id": 14843072,
    "user": {
      "login": "illicitonion",
      "id": 1131704,
      "avatar_url": "https://avatars.githubusercontent.com/u/1131704?v=3",
      "gravatar_id": "",
      "url": "https://api.github.com/users/illicitonion",
      "html_url": "https://github.com/illicitonion",
      "followers_url": "https://api.github.com/users/illicitonion/followers",
      "following_url": "https://api.github.com/users/illicitonion/following{/other_user}",
      "gists_url": "https://api.github.com/users/illicitonion/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/illicitonion/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/illicitonion/subscriptions",
      "organizations_url": "https://api.github.com/users/illicitonion/orgs",
      "repos_url": "https://api.github.com/users/illicitonion/repos",
      "events_url": "https://api.github.com/users/illicitonion/events{/privacy}",
      "received_events_url": "https://api.github.com/users/illicitonion/received_events",
      "type": "User",
      "site_admin": false
    },
    "position": 5,
    "line": 5,
    "path": "README.md",
    "commit_id": "e8da5c82f69503727ab683f503aeb1fbd7279f78",
    "created_at": "2015-12-08T10:05:07Z",
    "updated_at": "2015-12-08T10:05:07Z",
    "body": "NINE IS TOTALLY WRONG"
  }
]

from github-pull-review.

kegsay avatar kegsay commented on June 12, 2024

These comments do not have any Patch information which means I can't make a LineComment correctly annoyingly... they should be able to be made without this information. A better data model would be:

PullRequest {
  commits: Commit[]
  comments: Comment[]
}

Commit {
  patch: Patch;
  lineComments: LineComment[];
}

Whereas atm we have:

PullRequest {
  lineComments: LineComment[];
  commits: Commit[];
}

Commit {}

LineComment {
  patch: Patch;
}

This needs to be sorted out before we can do this. On the plus side, the glue is in place now request-wise, so it should be a quick fix once this is done.

from github-pull-review.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.