kemirdin / hyf-javascript1 Goto Github PK

dear Kemirdin, nice work you can clear your issues

Hi Kemirdin,

Here is my feedback on your homework.

First of all, thanks for trying to be helpful by including screenshots showing the output of your programs. However, I prefer to run your programs myself and inspect the produced output. For instance, you may have made some last minute changes and forgot to update the screenshots. Generally speaking, you should only include original files in your repo and exclude any derived files, as there is no easy way of telling whether the derived files actually are a true reflection of the originals.

Your JavaScript files are well formatted without any spelling errors.

Nice that you consistently used let instead of var.

It is also helpful that you included the assignment as comment lines in your files.

As a minor point, you should not have more than one blank line at the end of each file.

You don't need a .eslintrc.json and .gitignore files in your week2 folder. The proper place to put them is in the repo's root folder (in this case hyf-javascript1). You have them there already.

3-variable

• missing 'use strict';

6-arrays

• We may have confused you guys with the word 'plurality'. We meant that the variable name (which was yours to choose) was in plural form, as for instance you did with pets, which is the plural form of the singular pet. But you got the idea anyway.

8-typeof

• Make sure that your variable names are in camelCase
• The typeof an array is object, as we chatted about in slack.
• Please use the triple form === (line 25) in preference over ==.

You've done a great job. Congrats!