kemirdin / hyf-javascript3 Goto Github PK

Hi Kemirdin, here is my feedback on your homework.

1. Your get...() methods should just return the data without prefixing it with a string, like you did here:

   return `Movie title: ${this.title}`;

   it should just do this:

   return this.title;

   Why? Suppose I want to use your movie class in another application or web page and use Dutch as the main language. Then I would like to use the term Filmtitel. So, add such string information at the point where your are going to present the information to the user, e.g. in console.log or where you are creating an HTML element and set its innerHTML.
2. There can be more than one rating and more than one writer (these are arrays). So you should use a plural name: this.ratings, this.writers.
3. Class names should start with an uppercase letter: movieStaff -> MovieStaff
4. Similar as I have mentioned under point 1 above, the getStars() should just return this.stars. This is one reason why the code you commented out doesn't work. An other reason is that you forgot the parentheses after getAge. The correct code is:

   console.log(PrisonBreak.getStars().map(actor => `${actor.getName()} ${actor.getAge()}`))

5. director is not an array. You can't use .map() on it.
6. Your .eslintrc.json file is invalid. The outer curly braces should be removed.

Hi Kemirdin, here is my feedback on your final homework.

Your homework does not completely implement the requirements from the homework assignment. It looks like you didn't get any further than step 3.7. And in particular I don't see the responses from GitHub being displayed as HTML elements in your web page. Instead, you just console.log the output.

As a potential employer I would probably not be satisfied with this result.

The code that you did write, in particular the XMLHttpRequest with promises is correct, albeit that I would prefer using the load event that we did in class rather than the more laborious onreadystatechange event handler.

I will now go through the criteria I have set for this final assignment.

1. Your code must run without errors.

   Meets requirement.

2. Your web page must be fit-for-purpose and well-designed. Place yourself in the role of an end-user: is the web page attractive and useful, or will you quickly click away?

   Your web page does not display any results. Therefore it does not meet this requirement.

3. Your code must be well-formatted.

   It looks like all your code is indented apart from 'use strict'. Perhaps you had curly braces after 'use strict' and at the end of the file to create a local scope, but removed them later. If I reformat your file all code shifts to the left. Apart from this minor point the code looks well formatted.

4. Your repo must contain an .eslintrc.json file. There should be no avoidable ESLint warnings in your code. If you can fix the warning, do so. Please be prepared to account for any remaining warnings.

   Your repo contains the required .eslintrc.json file. I do see an ESLint warning in line 52, where you have specified a parameter named statusCode but used a non-existing variable named status in line 53.

5. There should be no spelling errors in variable and function names, text strings and comments. If the VSCode spelling checker flags certain words as incorrect (and sometimes that is inevitable) you should be able to explain why that is. If you are uncertain about some word, consult an English dictionary.

   In line 24 a spelling error is flagged that you did not correct: succesfully -> successfully.

   There is also a spelling error in function uerDetailsResponse which should be userDetailsResponse (the spelling checker for some reason missed this one).

6. Variable and function names must conform to these naming conventions.

   The variable name URL in lines 33 and 40 should be spelled in lowercase: url. All other variable and function names are correct.

7. Consider blank lines to convey a meaning, similar to using blank lines to separate paragraphs in a piece of written text. A blank line between function/method definitions is fine. A blank line that breaks up a piece of code that actually belongs together is wrong. Whenever you add a blank line, carefully consider whether the blank line helps or hurts readability. Keep it in only if it helps.

   Meets requirement.

8. There should be no commented out code in your final homework. (Just like you wouldn't leave crossed out text in your CV).

   Meets requirement.

9. There should be no unnecessary console.log statements in your final code. These statements are fine when developing and debugging, but not in your final product (and, as per point 8 above, don't just comment them out).

   You still have console.log statements in the makeMyXHR function that should not be present in final code.

10. Review your own code as if you were an employer yourself. Would you offer yourself an internship or job when running and looking at the code?

    I'll let you be the judge of that.

hey Kem,
1- on line 75 we only have one film so you don't array but you will need it for stars since we have many stars.
2- in the constructor, you can have only title and director:

constructor(title, director) { this.title = title; this.director = director; this.stars = []; this.ratings = []; }

3- The push method only for arrays

Hi Kemirdin. Your page looks very pretty and cute. But it doesn`t work which I expected. I will recommend you to check your code again.

Hi Kemirdin,

I'm pleasantly surprised by your latest homework. I must revise my earlier assessment of your progress. Well done!

Som minor comments:

1. In your hyfListResponse function you use the createAndAppend function. However, in your uerDetailsResponse function (which has BTW still the spelling error I noted before) you don't use the createAndAppend function, but use separate creaetElement and appendChild method. This is inconsistent.

2. I wouldn't show the contributors for every repo of a user. This is less relevant and you can quickly reach the GitHub API request limit of 60 per hour.

I have already posted my implementation of the homework. Please check that one for details how you can chain promises together and catch errors at the end.