Undefined names about slm-lab

[kengz]

Hi, the tests are set up to run with pytest, so other test frameworks will likely fail. Could you try and confirm the following terminal commands?

# to activate the install dependencies
conda activate lab
# run the official test which calls pytest
python setup.py test

The tests are also ran on the build https://circleci.com/gh/kengz/SLM-Lab/1970

[cclauss]

See #136 flake8 will find undefined names which might not be discovered by other linters or tests.

Each undefined name has the potential to raise NameError at runtime.

[kengz]

unclear what problem this aims to solve; there is no breakage in the code referred. closing as irrelevant.

[kengz]

reopening issue:
TODO: see #137 for some context; write proper regression tests.

[kengz]

fixed by #139

[cclauss]

From 11 above down to 7 below... Undefined names have the potential to raise NameError at runtime.

flake8 testing of https://github.com/kengz/SLM-Lab on Python 3.7.0

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./slm_lab/env/base.py:25:49: F821 undefined name 'nvec'
        setattr(gym_space, 'low', np.zeros_like(nvec))
                                                ^
./slm_lab/agent/algorithm/base.py:84:16: F821 undefined name 'action'
        return action
               ^
./slm_lab/agent/algorithm/base.py:91:16: F821 undefined name 'batch'
        return batch
               ^
./slm_lab/lib/viz.py:299:16: F821 undefined name 'TimeoutExpired'
        except TimeoutExpired:
               ^
./slm_lab/experiment/search.py:133:9: F821 undefined name 'config'
        config['trial_index'] = self.experiment.info_space.tick('trial')['trial']
        ^
./slm_lab/experiment/search.py:135:16: F821 undefined name 'config'
        return config
               ^
./slm_lab/experiment/search.py:148:16: F821 undefined name 'trial_data_dict'
        return trial_data_dict
               ^
7     F821 undefined name 'action'
7