kentcdodds / beginners-guide-to-react

The Beginner's Guide To ReactJS

The Beginner's Guide to React

Watch The Beginner's Guide to React for free on egghead.io.

If you wish to play with the finished examples, you can do so in this repository. It's not required to learn from the course (these are not exercises).

To run the dev server, run the start file. If your operating system does not know how to run the "start" file, simply copy its contents into a command terminal to start the server.

beginners-guide-to-react's Issues

26-http-errors.html : error state not required

In HTML file 26-http-error.html

Since we are hardcoding the message as well error message corresponding to each status we are getting via the status state.
So we don't require an error state to separately manage the error that we are getting from the fetchPokemon() API call. I think keeping the error state is redundant code, solution could be to remove this state or use that error message to display it to the user in some way.

How about give MIT license on this guide repository?

Thank you for your great guide to react.

You said on twitter this lecture will be free forever. (It was amazing.)
I found this repository has no license which means it is default license on it.
Many people already fork this guide sources.

How about give MIT license on this repository. To many other people learn free and feel free to share this great lecture and source to introduce react fundamentals.

Changing the graphql query does not give a network error

Thank you very much for the free course, really good material!

---

In master branch 25-http.html

if you change the name to nam like in the video, it does not give a network error but still provide correct response for the pokemon name (ex: mew)

const pokemonQuery = `
        query PokemonInfo($name: String) {
          pokemon(name: $name) {
            id
            number
            name
            attacks {
              special {
                nam
                type
                damage
              }
            }
          }
        }`;

Why is that I am confused?

Create a "start.bat"

Start works on Windows (assuming that npx is present and would usually work), however simply running it causes Windows to ask how to do so (or what to open it with).

Literally copy/pasting it as start.bat is enough for Windows to recognise it as an executable or something to be run under a shell; there might be other ways this could be done:

• A short cut (but how one makes those as something one can check into Git, I'm not sure)
• An executable (but why - a batch file seems to work)

Alternatively, a README could be created which says something like:

If your operating system does not know how to run the "start" file, simply copy its contents into a command terminal to start the server.

[Off topic to this ticket, though, thanks for creating the free course]

Pokmon API is not available anymore: https://graphql-pokemon.now.sh

This issue: https://github.com/kentcdodds/react-hooks/issues/28 applies to this project as well. Specifically:

This API is no longer working:

"ZEIT Now 1.0 is being shut down. As part of this, all ZEIT Now 1.0 Deployments will become inaccessible."

The owner of the repo has been notified already: lucasbento/graphql-pokemon#13

But it seems unlikely anything will happen here. I tried to get the project up and running so I could deploy it elsewhere but that didn't work right away and I didn't have the time to figure out what was wrong with their project.