kentcdodds / static-testing-tools

Static Analysis Testing JavaScript Applications on TestingJavaScript.com

Static Testing Tools

TestingJavaScript.com

static-testing-tools's Issues

ReferenceError: utils is not defined

cloned this repo, did a npm i then npm t and the error occurred:
PASS jest src/tests/spy.js
FAIL jest src/tests/external-mock-module.js
● returns winner

ReferenceError: utils is not defined

  13 | 
  14 |   // cleanup
> 15 |   utils.getWinner.mockReset()
     |   ^
  16 | })
  17 | 

I thought lets but this course as i got tired of all the blogs that claimed to work but dont and now here are same problems, slightly disappointed, probably is problem between keyboard and the back of my chair :)
regards, sorry close this was on wrong repo,should be on your js-mocking fundamentals
Ronald

[INFO] [CHORE] husky is updated | Ideology is same

Just suggestions:

• husky now creating the new .husky folder
• and pre-commit also added under .husky

may be we would like to update the testing video for husky or docs here.
But your suggestions on husky as tool ideology is not changed.

lint-staged and husky updates

You're probably aware, but thought I'd pass along:

With lint-staged, it looks like "linters": {} is no longer needed. Going straight to the commands works

Husky shows a warning that putting hooks in npm scripts will be deprecated. They offer a few other ways - e.g. putting them in package.json

Invalid "extends" eslint config option inside "overrides" entry

This happens in the code for the lesson to add support for eslint to support TypeScript files. In that lesson there's an instruction to add a "extends" config inside the "overrides" section intended to tailor the eslint config for TypeScript files.

Here's the exact line:

static-testing-tools/.eslintrc

Line 24 in 2854551

"extends": [

eslint-config-prettier/@typescript-eslint is not required for >=8.0.0

In https://testingjavascript.com/lessons/javascript-make-eslint-support-typescript-files , overrides for .ts | .tsx file contains eslint-config-prettier/@typescript-eslint in the extends.

As per https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21 it is no longer required. Extending 'prettier' in the eslintrc would take care of conflicting typescript rules as well.

.vscode folder is not saved to Github

Two videos, including https://testingjavascript.com/lessons/javascript-use-the-prettier-extension-for-vscode, are about editing the user's VScode settings file. However, that code seems to be missing from this Git repo.

I have checked the branches for the related videos including https://github.com/kentcdodds/static-testing-tools/tree/tjs/step-05.

Extra Branches/Step Inconsistencies

There seems to be some extra branches in the repo:

Also it seems like some of the branches are not matching up with the videos. For example, I checked out tjs/step-11 and it has the completed code for 11, 12, and 13.

lint-staged only runs ESLint on .js files

Shouldn't ESLint run on at least jsx files as well?

static-testing-tools/08-auto-format-all-files-and-validate-relevant-files-in-a-precommit-script-with-lint-staged/.lintstagedrc

Line 3 in 860492a

"*.js": [

Husky v5

Could you please update this lesson with the latest version of husky and lint-staged?

Issues visual studio code

Hi, I had some issues in visual studio code, some files have errors:
See image:
https://www.screencast.com/t/Qa0lU5U6

Also I have issues installing Jest:
https://www.screencast.com/t/CCFzw6ZZMEoJ

Thanks