kevinlieser / http2_push Goto Github PK

When opening a page that has a lot of different images the "link" header gets very long (see also #7 ) and on our server results in a server error 500. The last working page before the error has a "link" header string length of 8099 so I assume the "breaking point" is around 8100 and 8200 characters. I am not sure if this is a server setting or dependent on the used software, in our case it is an Apache server. It is also possible, that what Chrome dev tools show me has a max limit since the string stops with "; rel=preload; as=image" and usually the "as=image" precedes a source.

The optimal solution would be a way that finds out the max length from the system, another might be a setting that caps the max length to prevent server errors with a medium sized default value.

I did not have any entries in my error logs when this error occurs.

I am working with "clear.gif" as a placeholder for lazy loaded images a lot and noticed, that the http2_push dumps every single occurrence into the link-header. This could blow up the header unneccesarily in some cases. This is a minor issue but I am sure can be fixed by reducing the array of found sources down to unique ones.

Here is a screenshot from my link-header-text:

Hello,

Is there any plan to release the new version of the extension which is compatible with TYPO3 9.5 LTS?

Thank you.

Hallo,

wir haben eine Typo3 9.5.5 mit PHP 7.3 installiert. Dann haben wir mit dem Composer dieser EX installiert und aktiviert. Nun erhalten wir folgende Fehlermeldung:
LIVE | ERROR | Error handler | Core: Exception handler (WEB): Uncaught TYPO3 Exception: #1294585866: No class named Ka\Http2Push\Hooks\ContentPostProcessor | InvalidArgumentException thrown in file /var/www/typo3/public/typo3/sysext/core/Classes/Utility/GeneralUtility.php in line 3585. Requested URL: https:// |  

Woran kann es liegen, denn die Class liegt im Ordner Classes/ Hook.

In my markup I have IMG tags that have a clear.gif as source and the real image URL as data attribute to be loaded when necessary. The http2_push plugin seems to be parsing all the image URLs from the finished markup and put them into the link header with rel=preload.

I suspect that the resource parser wrongfully mistakes the data-isrc= with a src=

I think the default behavior should not include sources that would not be loaded by the browser if the markup was parsed normally.

Maybe this can be a configuration/setting for the plugin? Like "parse sources from data-http2push attributes in the markup".

https://www.w3.org/TR/preload/

A few things are missing like fonts and other assets.

https://developer.mozilla.org/en-US/docs/Web/HTML/Preloading_content

Hello,

I've installed http2_push extension on my website, and it works well in all other browsers except safari.
In safari, the website is not loading. Please see the attached screen. Do we've any solution for this?

Thank you.