GithubHelp home page GithubHelp logo

Comments (1)

Brianzchen avatar Brianzchen commented on June 5, 2024

I believe your old codebase has been using aphrodite wrong this whole time. You don't need to add styles in componentWillReceiveProps.

Firstly, I would ask are you using styles anywhere outside of the render() function? If not then just move your styles creation to render() like so,

class Comp extends React.Component {
  render() {
    const styles = (args) => StyleSheet.create({
      something: {
        width: this.props.width,
        // ... and anything else
      },
    });

    return (
      <div className={css(styles.something)} />
    );
  }
}

If you are assigning styles to this.styles because you have some other use case for styles besides rendering components then I would ask what that is and we can figure that out. Otherwise there's no reason to use more methods and overcomplicate your styling solution.

from aphrodite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.