GithubHelp home page GithubHelp logo

Comments (4)

costela avatar costela commented on June 9, 2024 1

This is such a weird coincidence! I just started working on a PR for this 😅

However, my PR currently deals with it from the package_bindings side, using a "magic" . package. The more general solution of matching the package path more intelligently requires a bit more refactoring - I think.

Will link it here as soon as the tests are done and we can see if it's enough.

from genqlient.

benjaminjkraft avatar benjaminjkraft commented on June 9, 2024

Ah, good find! I think the ideal place to update this would be in generator.ref/generator.addImportFor? Those should be able to see whatever we know about the current package and just have a special case. (But somewhere you may have to figure out -- or ask Go -- what the full package path for the current package even is.)

from genqlient.

costela avatar costela commented on June 9, 2024

Got a first attempt in #285.

Reworked my approach to make it work with bindings + package_bindings equally well.

Getting the fully qualified package is a bit fiddly and I'm not entirely sure it's "safe" (it relies on relative imports, which AFAICT have a rocky support history). But is seems to work.

PTAL

from genqlient.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.