Comments (4)
This is such a weird coincidence! I just started working on a PR for this
However, my PR currently deals with it from the package_bindings
side, using a "magic" .
package. The more general solution of matching the package path more intelligently requires a bit more refactoring - I think.
Will link it here as soon as the tests are done and we can see if it's enough.
from genqlient.
Ah, good find! I think the ideal place to update this would be in generator.ref
/generator.addImportFor
? Those should be able to see whatever we know about the current package and just have a special case. (But somewhere you may have to figure out -- or ask Go -- what the full package path for the current package even is.)
from genqlient.
Got a first attempt in #285.
Reworked my approach to make it work with bindings
+ package_bindings
equally well.
Getting the fully qualified package is a bit fiddly and I'm not entirely sure it's "safe" (it relies on relative imports, which AFAICT have a rocky support history). But is seems to work.
PTAL
from genqlient.
Related Issues (20)
- config option `optional` is not validated HOT 1
- Add Go 1.20 to tests
- Drop Go <1.18 HOT 3
- Global omitempty option HOT 12
- Make it easier to integration test config options
- Premarshal struct does not maintain JSON tags (omitempty) HOT 6
- Handling enums with strings that have variations of character casing HOT 2
- genqlient: command not found HOT 2
- [Meta] Document and improve support for Hasura & Dgraph schemas HOT 7
- Nullable list in optional pointer mode generates non-pointer slice HOT 2
- invalid character '<' looking for beginning of value HOT 4
- Inline fragments not working with `use_struct_references: true` and `pointer: optional` HOT 4
- codegen error: 'data' redeclared in this block HOT 1
- Split `TestGenerateWithConfig` cases
- Cannot use Go keywords as variable names in mutation. HOT 1
- panic: runtime error: invalid memory address -- generate.go:403 HOT 4
- `# @genqlient(for: "Input.nonOptionalField", omitempty: false)` not working HOT 4
- Test that all snapshots are used
- Is there a way to access the raw http response? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from genqlient.