Comments (4)
benjaminjkraft
commented on June 26, 2024
1
Thanks for raising this. I agree this is a bug. We can probably just change the validation (here and a few
similar places in the same file) to only reject omitempty: true, not omitempty: false on non-nullable fields. Or, more correct (although probably more work) would be to just change the behavior so a global omitempty only applies to non-nullable fields; I don't see how that behavior as-is could be useful (and in most cases it just doesn't matter -- only if you try to pass the Go zero value which I assume is where you are finding trouble).
from genqlient.
Anas737
commented on June 26, 2024
Thank you for looking into it
from genqlient.
Related Issues (20)
- config option `optional` is not validated HOT 1
- Add Go 1.20 to tests
- Drop Go <1.18 HOT 3
- Global omitempty option HOT 12
- Make it easier to integration test config options
- Premarshal struct does not maintain JSON tags (omitempty) HOT 6
- Handling enums with strings that have variations of character casing HOT 2
- genqlient: command not found HOT 2
- [Meta] Document and improve support for Hasura & Dgraph schemas HOT 7
- Nullable list in optional pointer mode generates non-pointer slice HOT 2
- invalid character '<' looking for beginning of value HOT 4
- Inline fragments not working with `use_struct_references: true` and `pointer: optional` HOT 4
- codegen error: 'data' redeclared in this block HOT 1
- Split `TestGenerateWithConfig` cases
- Binding to a type in the same package as generated code produces invalid output HOT 4
- Cannot use Go keywords as variable names in mutation. HOT 1
- panic: runtime error: invalid memory address -- generate.go:403 HOT 4
- Test that all snapshots are used
- Is there a way to access the raw http response? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from genqlient.