GithubHelp home page GithubHelp logo

Comments (13)

rmader avatar rmader commented on July 22, 2024

For the record: it may make sense to rename it to EGL_ANGLE_sync_control to match EGL_ANGLE_sync_control_rate (#116)

from egl-registry.

oddhack avatar oddhack commented on July 22, 2024

We don't include extensions in the registry unless the authors ask for them to be included. Given the age of the extension, it was probably done internally at that time and the author simply didn't realize, or forgot to submit it here, then moved on to other things. The only identified contact is Stéphane Marchesin and if you want to reach out to them, or to the Chromium project, and ask them to submit the extension here, that would be great.

from egl-registry.

stonesthrow avatar stonesthrow commented on July 22, 2024

👍

from egl-registry.

pasikarkkainen avatar pasikarkkainen commented on July 22, 2024

I managed to contact Stéphane Marchesin who is marked as the contact for EGL_CHROMIUM_sync_control extension in the spec. This is the response I got:

For Chrome OS (which is what I work on, and why this extension was made),
we have stopped using sync_control circa 2015, when Chrome OS moved all
the WSI stuff outside of the driver. Now we use external eglimages as our
render targets, and then take those buffers to DRM/KMS directly to display
them. In other words, we don't use eglSwapBuffers and friends, and as such
we don't have a need for this extension because we do our own frame
scheduling directly on the display driver.

EGL_CHROMIUM_sync_control extension is marked as "Related" in another recently merged EGL_ANGLE_sync_control_rate extension ( https://github.com/KhronosGroup/EGL-Registry/blob/master/extensions/ANGLE/EGL_ANGLE_sync_control_rate.txt ) so for completeness it would of course be good to have EGL_CHROMIUM_sync_control spec merged aswell, but it sounds like google does not have interest for the extension anymore..

from egl-registry.

oddhack avatar oddhack commented on July 22, 2024

... so for completeness it would of course be good to have EGL_CHROMIUM_sync_control spec merged aswell, but it sounds like google does not have interest for the extension anymore..

Realistically all that can be done is to create a stub extension specification quoting what you've learned here, in case someone raises the question in the future, and likewise create a stub extension interface in egl.xml (or an actual extension if the API is known from their SDKs). If you want to make a PR along those lines I think it would be accepted - you would want to include a disclaimer in the "specification" saying that it is not an official Google submission, just a community attempt to document the old extension. We have a few GL extension specs like that already.

from egl-registry.

stonesthrow avatar stonesthrow commented on July 22, 2024

Checking back, is this issue ready for closure? or do you have action?

from egl-registry.

pasikarkkainen avatar pasikarkkainen commented on July 22, 2024

Well, as it seems the original authors are not interested in creating a PR for this, i guess I can copy the extension spec from https://chromium.googlesource.com/chromium/src/gpu/+/refs/heads/main/GLES2/extensions/CHROMIUM/EGL_CHROMIUM_sync_control.txt and create a PR here, with the notes @oddhack mentioned..

I won't have time for this right now, but hopefully I will have before not too long from now.
Thanks for pinging @stonesthrow

from egl-registry.

stonesthrow avatar stonesthrow commented on July 22, 2024

I'll leave open for you to follow up then.

from egl-registry.

stonesthrow avatar stonesthrow commented on July 22, 2024

ANGLE has both extensions in angle/extensions.
The EGL registry has EGL_ANGLE_sync_control_rate.txt
So its up to Chromium if EGL_CHROMIUM_sync_control is added to the registry.
If this is not important, then lets close this issue.

from egl-registry.

pasikarkkainen avatar pasikarkkainen commented on July 22, 2024

It seems we don't have any EGL_CHROMIUM extensions in EGL-Registry so far.

Thus I'm not sure if I'm allowed to copy and add "EGL_CHROMIUM_sync_control" extension myself, as that would introduce the whole CHROMIUM directory.. what's the policy on that? Does the directory need to be added by someone from CHROMIUM ?

Would be good if someone from CHROMIUM did this, but I guess they haven't been interested in having their extensions in EGL-Registry ..

from egl-registry.

stonesthrow avatar stonesthrow commented on July 22, 2024

It would be totally up to the Chromium team, whether they want to add/expose extensions to the registry or not. I can try and contact someone, but since they have not published any extensions, I would think that is their policy.
Let me ask a few Googlers on the Chromium team and see if there is a policy. But neither I or you should because its a vendor purview.

from egl-registry.

stonesthrow avatar stonesthrow commented on July 22, 2024

"The ANGLE policy is to skip upstreaming extensions unless we determine it's needed for other teams (outside Google generally)."

  • I will use this as Chromium policy. So no Chromium extensions will be expected.
    So this issue can be closed and will not fix.

from egl-registry.

stonesthrow avatar stonesthrow commented on July 22, 2024

Will not add extension to registry per Chromium policy.

from egl-registry.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.