GithubHelp home page GithubHelp logo

f3-plugins's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

f3-plugins's Issues

CodeSniffer Friendly Formatting

  • axonrest.php
  • currency.php
  • systemprofile.php
  • tablebuilder.php

Just need to make the commenting more standard, shift to spaces rather than tabs, and some other stuff.

Add unit tests

Still need unit tests for:

  • axonrest.php
  • currency.php
  • systemprofile.php
  • tablebuilder.php

None-numric id's (security issue?)

There is a problem when using none-numric ID's.
1: It wont load correctly
2: Under special circumstances it will return the first DB entry independent of the actual ID...

I've corrected it in my local version by applying the following patch:

Index: axonrest.php

--- axonrest.php (revision 164)
+++ axonrest.php (working copy)
@@ -81,9 +81,12 @@
// Now load this mess.
$x = new AxonHelper($name);
if ($where !== null) {

  •       if (is_numeric($where)) {
    
  •           $where = sprintf("id=%d", $where);
    
  •       }
    
  •       if (is_string($where)) {
    
  •           $where = sprintf("id='%s'", mysql_escape_string($where));
    
  •       } else {
    
  •           $where = sprintf("id=%d", (int)$where);
    
  •                    }
        $x->load($where);
    }
    return $x;
    

@@ -163,7 +168,7 @@
}

    if (!empty($object_id)) {       
  •       $object = self::getObject($object_name, intval($object_id));
    
  •       $object = self::getObject($object_name, $object_id);
        if ($object->dry()) {
            f3::http404();
        } else {
    

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.