kiva / aries-guardianship-agency Goto Github PK

Currently we call agents directly when sending basic message. See

Instead we should use AgentService: https://github.com/kiva/aries-controller/blob/ac76a7171555eaacf50df77bb78e0b7d4322b62e/src/agent/agent.service.ts#L96

Because TSLint is now deprecated in favor of ESLint, we should migrate to use ESLint.

We may be able to do this quickly by using https://github.com/typescript-eslint/tslint-to-eslint-config.

Add helm charts and update Circle CI config to automatically deploy aries-guardianship-agency to the dev environment once protocol-integration-tests pass and a new docker image has been pushed to dockerhub.

There is still one place where we require running a custom sql script: resources/init.sql This should be moved to a typeorm migration as we expect all database schemas to be fully managed by their relevant services. When writing the script, make sure to use CREATE IF NOT EXISTS syntax in the sql so as to avoid errors around creating duplicate postgres resources.

Like was done for protocol-gateway and aries-key-guardian, this ticket is to continue the work of continue phasing out the use of ts-node, targeting aries-guardianship-agency next.

I am getting this issue when i try to run

aries-guardianship-agency    | /www/node_modules/jose/lib/help/rsa_primes.js:6
aries-guardianship-agency    | const ZERO = BigInt(0)
aries-guardianship-agency    |              ^
aries-guardianship-agency    | ReferenceError: BigInt is not defined
aries-guardianship-agency    |     at Object.<anonymous> (/www/node_modules/jose/lib/help/rsa_primes.js:6:14)
aries-guardianship-agency    |     at Module._compile (module.js:653:30)
aries-guardianship-agency    |     at Object.Module._extensions..js (module.js:664:10)
aries-guardianship-agency    |     at Module.load (module.js:566:32)
aries-guardianship-agency    |     at tryModuleLoad (module.js:506:12)
aries-guardianship-agency    |     at Function.Module._load (module.js:498:3)
aries-guardianship-agency    |     at Module.require (module.js:597:17)
aries-guardianship-agency    |     at require (internal/module.js:11:18)
aries-guardianship-agency    |     at Object.<anonymous> (/www/node_modules/jose/lib/help/key_utils.js:9:23)
aries-guardianship-agency    |     at Module._compile (module.js:653:30)
aries-guardianship-agency    | [nodemon] app crashed - waiting for file changes before starting...```

This API was intended to allow the TRO to refresh the state of onetimekey
{GuardianshipEndpoint}/v2/transaction/{AgentId}/ids/

However, the TRO actually needs to be able to retrieve its tdc_tro_id Id for a given onetimekey value.

options:

1. add db table that allows TRO to save state as communicated via basic message. we are currently using a db for transactions records so its easy to use. however, we may wish to get rid of the db once the correctness proof can be finalized
2. add record to wallet. using the wallet for this kind of data is really beyond the design of the wallet. however, see point 1 above.
3. Have AGA request this information from the TDC. This will require a change in the API and need to be careful the change does not result in dataleakage we do not want.

There is a work around:

1. FSP sends the one time key value first
2. TRO sends the one time key value second, and the return value from this call will return the tdc_tro_id ids.

To avoid overloading "controller" too much, let's change the name of the ControllerModule and the various files that are called agent.controller to use "webhook" instead. We can also change the url to v2/webhook (and ensure our env vars are updated everywhere to reflect that).

Make the functionality unit testable (not integration testable) which can be run from the command line without docker required.

see aries-key-guardian for example

The results are inconsistent between these two messages and they should be the same.

see OneTimeKey Message and Refresh OneTimeKey Message in https://docs.google.com/document/d/1-pDTcXIh1DPPu_QatD5-jHHsp0fIaQQtD2Ha9Uswa3Y/edit#

Before pushing a new docker image, we should run protocol-integration-tests and make sure they pass. This is a quality check that will prevent us from having bad versions of this repo deployed to dockerhub.

Once we have updated to aca py 0.7.0 we can take advantage of the new variable "--admin-client-max-request-size". This defafaults to 1 (ie 1 MB) with a max of 16. This ticket is to add the new aca py start up arg to https://github.com/kiva/aries-guardianship-agency/blob/main/src/manager/agent.config.ts#L144 , and I think to be safe, set the value to 16. You should also test that it works and that aca-py can now accept larger request sizes (eg photos)

when AGENT_GUARD_ENABLED is false basic messages send correctly. however, that means authentication is off.

Add date, type and amount to report records since we cannot pull it from the credential at this time.

Notes:
I tried to abstract the calling of the agent, whether single or multi, behind a caller interface: https://github.com/kiva/aries-controller/blob/main/src/caller/caller.interface.ts
caller.interface.ts
export const CALLER = 'CALLER';

export interface ICaller {

/**

Show more
https://github.com/kiva/aries-controller|kiva/aries-controllerkiva/aries-controller | Added by GitHub
10:00
Used like this: https://github.com/kiva/aries-controller/blob/main/src/issuer/issuer.service.ts#L30
issuer.service.ts
@Inject(CALLER) private readonly agentCaller: ICaller,
https://github.com/kiva/aries-controller|kiva/aries-controllerkiva/aries-controller | Added by GitHub
10:00
then you can use callAgent() https://github.com/kiva/aries-controller/blob/main/src/issuer/issuer.service.ts#L315
issuer.service.ts

but looking at