Comments (4)
Hi
The Popover component should not wrap the Input, as the Input is not what triggers the Popover. Do you have any reasoning for doing it like that?
Your workaround seems to be a valid solution.
from orbit.
Hi,
I thought the popover should wrap the input because it is triggered by a button inside the input. I tried wapping just the button, but that caused layout bugs. If you don't see any problems with my workaround, I'm happy to leave it like that. Though I am curious as to why the space events not registering?
Many thanks for your reply.
from orbit.
I understand your thought, but yeah, in this case, there should be a wrapper around the component so that the positioning of the Popup is the one desired.
The keydown event for the space key is being captured on children of the Popover, so that one can open the Popover using the space key. It is defined here, and is the desired behavior. Therefore, if the Input is a children of the Popover, the SPACE event will be captured and not propagated.
from orbit.
I see, thanks for clearing this.
from orbit.
Related Issues (20)
- Prevent drawer overlay close HOT 7
- Padding right added to body when modal opened HOT 4
- Add option for select widget to have icon only
- Possibility to set timeline direction HOT 2
- available `icon list` is broken HOT 2
- ThemeProvider doesn't pass down dictionary prop properly HOT 1
- How to integrate using Rollup with orbit-components as the dependency? HOT 3
- Search shortcut (⌘ + K) doesn't work properly on FF HOT 4
- Accordion Component Broken in Latest Version
- Unable to remove white background on corners of Select component HOT 1
- Slider : show the histogram on desktop devices
- "TypeError: Cannot read properties of undefined (reading 'spaceXLarge')" when setting "content" on ItinerarySegmentDetail
- Reporting a vulnerability HOT 1
- align attribute not working in Heading component
- Allow different colored Tile Components HOT 2
- Custom Option filtering for InputSelect HOT 1
- Unexpected error when using OrbitProvider & `useId` prop HOT 6
- Dark Mode Support for Modals, Inputs, etc. ?
- DatePicker Component HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from orbit.