GithubHelp home page GithubHelp logo

Comments (4)

DSil avatar DSil commented on June 15, 2024

Hi

The Popover component should not wrap the Input, as the Input is not what triggers the Popover. Do you have any reasoning for doing it like that?

Your workaround seems to be a valid solution.

from orbit.

yairau avatar yairau commented on June 15, 2024

Hi,

I thought the popover should wrap the input because it is triggered by a button inside the input. I tried wapping just the button, but that caused layout bugs. If you don't see any problems with my workaround, I'm happy to leave it like that. Though I am curious as to why the space events not registering?

Many thanks for your reply.

from orbit.

DSil avatar DSil commented on June 15, 2024

I understand your thought, but yeah, in this case, there should be a wrapper around the component so that the positioning of the Popup is the one desired.
The keydown event for the space key is being captured on children of the Popover, so that one can open the Popover using the space key. It is defined here, and is the desired behavior. Therefore, if the Input is a children of the Popover, the SPACE event will be captured and not propagated.

from orbit.

yairau avatar yairau commented on June 15, 2024

I see, thanks for clearing this.

from orbit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.