preg_match(): Compilation failed: missing ) about gitlist

[klaussilveira]

Can you provide the last part of the error (in ...) ? Also, is this repository public or private? If public, can you provide a copy for testing purposes?

[YMDH]

This is the complete error log. I printed out the parameters of the preg_match as wel:
Warning: preg_match(): Compilation failed: missing ) at offset 52 in /volume1/web/sparkle/vendor/symfony/routing/Symfony/Component/Routing/Matcher/UrlMatcher.php on line 132
#^(?:/(?[\w-.]+)/tree(?:/(?[\w-.]+)(?:/(?.+)/$#s
/Mygitrepo/tree/master/
Array ( )
Warning: preg_match(): Compilation failed: missing ) at offset 67 in /volume1/web/sparkle/vendor/symfony/routing/Symfony/Component/Routing/Matcher/UrlMatcher.php on line 132
#^(?:/(?[\w-.]+)/blob(?:/(?[\w-.]+)(?:/(?.+)/$#s
/Mygitrepo/tree/master/
Array ( )
Warning: preg_match(): Compilation failed: missing ) at offset 67 in /volume1/web/sparkle/vendor/symfony/routing/Symfony/Component/Routing/Matcher/UrlMatcher.php on line 132
#^(?:/(?[\w-.]+)/raw(?:/(?[\w-.]+)(?:/(?.+))?)?)?)?$#s
/Mygitrepo/tree/master/
Array ( )
Warning: preg_match(): Compilation failed: unmatched parentheses at offset 70 in /volume1/web/sparkle/vendor/symfony/routing/Symfony/Component/Routing/Matcher/UrlMatcher.php on line 132
#^/(?[\w-.]+)/commits(?:/(?[\w-.]+))?$#s
/Mygitrepo/tree/master/
Array ( )

[klaussilveira]

I'll try to reproduce the error, but it would be nice if you could share the failing repository. Thanks.

[YMDH]

It's a private repository, containing some very personal information from a small company, so I can't share it...

[klaussilveira]

Can i see your config.ini, at least?

[YMDH]

Here it is:
[git]
client = '/opt/bin/git' ; Your git executable path
repositories = '/volume1/SparkleShare/' ; Path to your repositories (with ending slash)

[app]
baseurl = 'http://my_domain_name/sparkle' ; Base URL of the application (without ending slash)

The my_domain_name is a perfect working uri

[klaussilveira]

Can you provide the output of ls -la on /volume1/SparkleShare/ ?

[YMDH]

Here you go:
$ ls -la /volume1/SparkleShare/
drwxr-xr-x 4 ydehauwe users 4096 Apr 17 09:02 .
drwxr-xr-x 17 root root 4096 May 29 09:45 ..
drwxr-xr-x 7 ydehauwe users 4096 Apr 17 09:02 Mygitrepo

[klaussilveira]

It's really hard to debug based on your input, i have no means to reproduce the error. Is there anything odd with the repository name or overall structure?

[YMDH]

$git init --bare test
Initialized empty Git repository in /volume1/SparkleShare/test/
gives
drwxr-xr-x 7 ydehauwe users 4096 May 31 08:11 test

and a lot of
Warning: preg_match(): Compilation failed: missing ) at offset 51 in /volume1/web/sparkle/vendor/symfony/routing/Symfony/Component/Routing/Matcher/UrlMatcher.php on line 132
at different offsets,
ending with Oops! No route found for "GET /test/tree/master/"

This seem to suggest that it is not a repository related issue.

[klaussilveira]

Apparently, it's a problem with Symfony's router, which Silex uses. However, this also might be caused by a minor bug in GitList. It's hard to pinpoint the issue without further information, but let me know if you can provide further data for me to reproduce the error.

[YMDH]

Could you add this code on line 131 in the UrlMatcher.php file to see what the output should be? It seems that the regex are wrong...

echo "<br/>".$compiledRoute->getRegex()."<br/>".$pathinfo."<br/>";print_r($matches); echo "<br />";

[klaussilveira]

I don't see what might be causing the regex to break. Your route is pretty simple and Silex's routing is (almost) rock-solid. I will investigate this further.

[eriknyk]

I've seen that error on some php versions with especial patterns within '? < name .... ',, that php version do you have @YMDH ?

[myano]

I'm getting the same problem too.

$ php --version
PHP 5.3.3 (cli) (built: May  4 2012 07:52:25) 
Copyright (c) 1997-2010 The PHP Group
Zend Engine v2.3.0, Copyright (c) 1998-2010 Zend Technologies

My error message is:

PHP Warning:  preg_match(): Compilation failed: unrecognized character after (?< at offset 5 in phar:///home/user/html/oursite/gitlist/vendor/silex.phar/vendor/symfony/routing/Symfony/Component/Routing/Matcher/UrlMatcher.php on line 132

GitList is in ~/html/oursite/gitlist/ and the repositories are in ~/html/oursite/projects/ The only repository I have in there now is the source code for gitlist and 'jenni' from my repository (just for testing purposes)

Here is my config.ini

[git]
client = '/usr/bin/git' ; Your git executable path
repositories = '/home/user/html/oursite/projects/' ; Path to your repositories

; You can hide repositories from GitList, just copy this for each repository you want to hide
; hidden[] = '/var/www/projects/BetaTest'

[app]
baseurl = 'http://oursubdomain.ourdomain.com/gitlist' ; Base URL of the application

; If you need to specify custom filetypes for certain extensions, do this here
[filetypes]
; extension = type
; dist = xml

The projects folder and Gitlist are all the appropriate user/group for apache to read/use them.

I get this error message Oops! No route found for "GET /jenni/tree/master/" when clicking 'jenni' on the GitList web interface and the URL before clicking it is, http://oursubdomain.ourdomain.com/gitlist/ and after clicking it is http://oursubdomain.ourdomain.com/gitlist/jenni/tree/master/

I am running the latest git clone of the project as of 2012/06/18 19:00 UTC (now).

[myano]

After doing some digging I'm curious as to what version everyone is using of PCRE. Run this and it'll show the version of PCRE that is installed:

pcregrep --version

On the box I'm trying to get Getlist to work it is: "version 6.6 06-Feb-2006"

I think the silex.phar is tripping up on this line:

line 27145: if (!count($compiledRoute->getVariables()) && false !== preg_match('#^(.)\^(?<url>.*?)\$\1#', $compiledRoute->getRegex(), $m)) {

[myano]

Yep, that fixed it.

Upgrade to a newer version of PCRE. I followed the instructions provided here: http://www.labalab.com/techblog/techtalk/php-warning-preg_match_all-compilation-failed-unrecognized-character-after-at-offset/

and that fixed it. I think at least 8.0 is needed not sure what the minimum possible version is needed.

[klaussilveira]

This is curious. @myano, which OS are you under and which package are you using for PHP installation?

Also, how do you guys wish to proceed regarding this issue? Mentioning the minimum of PCRE 8.0?

[myano]

@klaussilveira

It is: Red Hat Enterprise Linux Server release 5.4 (Tikanga)

uname -a: 2.6.18-194.17.4.el5 #1 SMP Wed Oct 20 13:03:08 EDT 2010 x86_64 x86_64 x86_64 GNU/Linux

PHP was installed via the repositories provided from our hosting company. We had to upgrade from PHP 5.1.x to 5.3.3

[eriknyk]

seems that problem is exclusive of RPM based packages like Centos,.. my friend had the same problem, and he was using centos too.
at the end he has installed ubuntu and it worked fine.

[klaussilveira]

Which PCRE version is the default in CentOS?

I have added a note about this on Troubleshooting: https://github.com/klaussilveira/gitlist/wiki/Troubleshooting

[myano]

@klaussilveira I'm not sure what the default version is on CentOS, but on the RHEL I was using it was 6.6-something dated in 2006, so it was pretty old. I have a feeling that this is suppose to be upgraded when PHP is upgraded as it is what the regexp's in PHP (from what I can tell) are using as a backend, unless Silex is specifically making an outside call to Perl.

[Peter-Hudson]

I came across this which shows the updates (that are still roughly in the same place) showing where the updates were made that stopped support for PCRE version 6.x - symfony/symfony@bc0c7ba

[YMDH]

Strangely enough, updating pcre did not fix the issue for me:

$ php -version
PHP 5.2.17 (cli) (built: Feb 24 2012 00:58:19)
Copyright (c) 1997-2010 The PHP Group
Zend Engine v2.2.0, Copyright (c) 1998-2010 Zend Technologies

$ pcregrep --version
pcregrep version 8.30 2012-02-04

[josenobile]

You need re-configure PHP, I did experiment same issue, update pcre will not fix the problem. ./configure --.. && make && make install in PHP source is required for work.