Wrong git binary autodetection path on php about gitlist

[klaussilveira]

GitList will always use an absolute path to the git binary. It has nothing to do with the php binary. Or i did not understand your answer correctly?

[shakaran]

Yep. But on some moment on Git Client class, the path initialized on the constructor is wrong, taking a diferent path no absolute or setted on config.ini.

[klaussilveira]

It will always use the path provided on config.ini. Only when nothing is provided, GitList will use the default /usr/bin/git.

[shakaran]

For me it's taking /usr/local/php/bin/git instead. Because maybe php doesn't find on included_paths the git binary.

$ php -i | grep PATH
safe_mode_protected_env_vars => LD_LIBRARY_PATH => LD_LIBRARY_PATH
PATH => /usr/local/jdk/bin:/home/myuser/perl5/bin:/usr/kerberos/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/bin:/usr/X11R6/bin:/home/myuser/bin
CLASSPATH => .:/usr/local/jdk/lib/classes.zip
_SERVER["PATH"] => /usr/local/jdk/bin:/home/myuser/perl5/bin:/usr/kerberos/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/bin:/usr/X11R6/bin:/home/myuser/bin
_SERVER["CLASSPATH"] => .:/usr/local/jdk/lib/classes.zip
_SERVER["PATH_TRANSLATED"] => 
_ENV["PATH"] => /usr/local/jdk/bin:/home/myuser/perl5/bin:/usr/kerberos/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/bin:/usr/X11R6/bin:/home/myuser/bin
_ENV["CLASSPATH"] => .:/usr/local/jdk/lib/classes.zip

[klaussilveira]

There is no relationship between the GIT binary and PHP's binaries. It's just a proc_open with absolute path to the binary to be executed. The git binary should not be in the PHP include_path, there's no need to.

[shakaran]

Pretty weird. I jus simply print the path and command:

    public function run(Repository $repository, $command)
    {
        echo 'Path:' . $this->getPath() . '
';
        echo 'Command:'. $command . '
';

        $descriptors = array(0 => array("pipe", "r"), 1 => array("pipe", "w"), 2 => array("pipe", "w"));
        $process = proc_open($this->getPath() . ' ' . $command, $descriptors, $pipes, $repository->getPat

It seems works fine:

Path:/usr/local/bin/git
Command:branch
Path:/usr/local/bin/git
Command:tag

Then I move the binary:

mv /usr/local/php/bin/git /usr/local/php/bin/git2

That results on:

Oops! sh: /usr/local/php/bin/git: No such file or directory

And it stills shows:

Path:/usr/local/bin/git
Command:show master:'other'

[klaussilveira]

Can you run a file /usr/local/bin/git and file /usr/local/php/bin/git?

[shakaran]

$ file /usr/local/bin/git
/usr/local/bin/git: ELF 64-bit LSB executable, AMD x86-64, version 1 (SYSV), for GNU/Linux 2.6.9, dynamically linked (uses shared libs), not stripped

$ file /usr/local/php/bin/git
/usr/local/php/bin/git: symbolic link to `/usr/local/bin/git'

[klaussilveira]

You're running PHP FPM?

[shakaran]

The code:

<?php echo php_sapi_name();

Returns:

cgi-fcgi

[shakaran]

Why it is closed? It is already resolved?