klaxit / danger-brakeman_scanner Goto Github PK

Hi, I encountered an error while using your library

Describing the error

It occurs when I try to run brakeman without supplying any options

# In Dangerfile
brakeman.run

It crashes with this error

/Users/goose/.asdf/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/danger-brakeman_scanner-0.1.1/lib/danger_plugin.rb:18:in `dirname': no implicit conversion of nil into String (TypeError)

  def run(options = File.dirname(Kernel.caller_locations.first.absolute_path))

I had a look and here's what I found:

1. It crashes in this line, specifically because Kernel.caller_locations.first.absolute_path is nil
2. According to this and this, absolute_path can return nil in some situations (those links are pretty old so I'm not sure if they're still hold true today). Using eval seems like one of them. and danger uses it

Dependencies version

• ruby (3.2.2)
• danger (9.3.1)
• danger-brakeman_scanner (0.1.1)
• brakeman (6.0.1)

Please let me know if there's anything missing