eyemusic's People
eyemusic's Issues
Design docs
Schema
- You should consider having separate tables for artists and albums if you need to have views for those resources or search by them
- I think you accidentally left some stuff about playlist_id right under the songs table part (or maybe you meant song?)
Other than that, the schema looks pretty good!
Sample state looks good!
PA Review: User Auth
Functionality
- The main button with logo should link to
/
- Has working demo login
- Smooth, bug free navigation
Before Login
- The
/login
page should not display a link toLog In
. Same for/signup
- Going to a random route
/#/oweiniouewbrviuwebv
should redirect or display a 404 page - Errors should display for both
/signup
and/login
. - Errors should clear when moving between
/signup
and/login
. - Can sign up a user
- Can sign in as a user
- Can log out a user
- Can't sign up with the same username/email
- Pressing enter after filling out the session form should use the form data, not the demo user
After Login
- Should not be able to visit
/login
or/signup
- Should be able to refresh the page and still be logged in
Style
- The site should look exactly like the actual site
- All relevant elements should have
cursor: pointer
on hover - When errors are displayed, most elements should not move around the page (particularly input boxes)
- Remove Redux logger and all console.log()'s from production
Seeds
- Adequate and appropriate seeds
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.