knicola / tdameritradejs Goto Github PK

Good job with this module.

There is an issue with the HTTP function returns. They return the complete HTTP response vs the body and the other functions expect the operate with the body.

For example;
const accounts = await api.getAccounts()
api.getOrders(accounts[0].accountId).then( ... )

accounts cannot be used like it is shown in the next line. It needs to be accounts.data[0]....

This is also the same issue with userPrincipals. It either needs to be returned with properties containing the body data, or the streamer functions need to reference the data property.

What exactly is the gap between the current package and one you would consider ready for production use?

Hello. Any chance you can put together a brief user guide? I'm able to get to the point where I receive the 'code' in the callback URL, but I'm not 100% sure what to do with it :) and/or how the access token/refresh token is persisted and used. Great work by the way!

Hello,
Awesome library, love it.

I have a question.

Once I get the token, and save it to a file (as you mention in the comments)

td.on('token', token => {
    // use this to know when a new access token is
    // issued or to save the token to a file.
    console.log(token)
})

How do I load the tokens (from the file) to the library, when the server restarts. So that I don't have to login using the link again, as I already have valid tokens saved in a file.

Thank you so much.

scripts/authorize.js is not structured to run when installed as a node module to be integrated into another app.

Certs are expected to be in the root of the module. This is not ideal for an application.

This could be a TD API limitation. Is there a way to pass frequency into the streamer for the futures contracts? Right now, it updates every minute. Can it be every 5 seconds, etc?

https://github.com/blais/ameritrade-api-schemas

Need to add methods for oauth authentication and token refresh:

• .authenticate() to request an access token
• .refreshToken() to request a new access token

Where can I find documentation for this library?

Suggested Openssl command in the readme didn't yield the expected results on macOS and Chrome browser.

This worked well:
openssl req -x509 -out selfsigned.crt -keyout selfsigned.key \ -newkey rsa:2048 -nodes -sha256 \ -subj '/CN=localhost' -extensions EXT -config <( \ printf "[dn]\nCN=localhost\n[req]\ndistinguished_name = dn\n[EXT]\nsubjectAltName=DNS:localhost\nkeyUsage=digitalSignature\nextendedKeyUsage=serverAuth")

https://developer.tdameritrade.com/content/streaming-data#_Toc504640593

note: connection drops after sending the request to the server without any warning message.

In src/client/resources/tokens.js there is a refreshAccessToken function. The function is intended to use an unexpired refreshToken to refresh an expired accessToken. In the function the parameter 'access_type' is being set to 'offline'. Per the documentation, "Set to offline to receive a refresh token on an authorization_code grant type request. Do not set to offline on a refresh_token grant type request."

My understanding is that this should only be set to offline when requesting the initial tokens (with the 'code' from the redirectURI).

When tested with 'offline' - this it returns both a refresh and access token.
When tested without 'offline' - this ONLY returns an access token (leaving the unexpired refreshToken still valid).

I will put together a PR for this change.

Hi, I am having trouble getting the login flow to work on node.js.
I copied the sample code you shared in a comment on issue #19, using a locally generated certificate/private key + API_KEY. Everything compiles and runs.
When the login() routine is invoked, it opens up my default web browser to the TD Ameritrade login page and 1. asks for my account credentials and 2. asks if I want to grant my app permission to access to my account. After a successful auth / grant, the browser is redirected to my REDIRECT_URI (e.g. https://localhost/?code=.....) but the node.js app just sits there. I tried closing the browser tab and the entire browser, but the node.js app just sits there, apparently not receiving back what it needs from the browser.
What am I missing here?

Please note I am using Windows 10, I am not sure if this matters for how your library handles this login process. The redirect also appears to be changing my REDIRECT_URI from HTTP to HTTPS so it fails to actually load my local app. Not sure if either of these factors are relevant here but I thought I'd mention both.

Thanks in advance, I'm looking forward to resolving these issues and working with this library.